[Bf-blender-cvs] [bac9b047788] blender2.8: Add comment about weird special handling of scene freeing in depsgraph.
Bastien Montagne
noreply at git.blender.org
Fri May 11 11:36:57 CEST 2018
Commit: bac9b047788a53677be7ecdcf755fcd90629185d
Author: Bastien Montagne
Date: Fri May 11 11:34:22 2018 +0200
Branches: blender2.8
https://developer.blender.org/rBbac9b047788a53677be7ecdcf755fcd90629185d
Add comment about weird special handling of scene freeing in depsgraph.
===================================================================
M source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc
===================================================================
diff --git a/source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc b/source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc
index fa988514e33..4e233fe14ff 100644
--- a/source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc
+++ b/source/blender/depsgraph/intern/eval/deg_eval_copy_on_write.cc
@@ -779,6 +779,9 @@ void deg_free_copy_on_write_datablock(ID *id_cow)
/* Special case for scene: we use explicit function call which
* ensures no access to other datablocks is done.
*/
+ /* Not sure why this is needed? If id_cow scene has been correctly created outside of Main database,
+ * then freeing it with regular BKE_id_free should properly *not* do any
+ * children datablock user refcount manipulation... --mont29 */
Scene *scene = (Scene *)id_cow;
BKE_scene_free_ex(scene, false);
BKE_libblock_free_data(id_cow, false);
More information about the Bf-blender-cvs
mailing list