[Bf-blender-cvs] [4df72208741] blender2.8: Fix crash with select linked when nothing is under the cursor

Dalai Felinto noreply at git.blender.org
Sun May 6 13:28:08 CEST 2018


Commit: 4df722087414366ea1014dbdbb10933031453369
Author: Dalai Felinto
Date:   Sun May 6 13:19:17 2018 +0200
Branches: blender2.8
https://developer.blender.org/rB4df722087414366ea1014dbdbb10933031453369

Fix crash with select linked when nothing is under the cursor

There is no object to update anyways, and there is no valid basact when the
nified_findnearest() test fails.

How to reproduce the bug: Try to select linked (L) with selected faces but
withotu mouse hovering any mesh.

Bug introduced on: rBbfc9d426bb95 (original multi-object edit commit).

===================================================================

M	source/blender/editors/mesh/editmesh_select.c

===================================================================

diff --git a/source/blender/editors/mesh/editmesh_select.c b/source/blender/editors/mesh/editmesh_select.c
index fdbddc91512..2c50f5ae189 100644
--- a/source/blender/editors/mesh/editmesh_select.c
+++ b/source/blender/editors/mesh/editmesh_select.c
@@ -3097,8 +3097,6 @@ static int edbm_select_linked_pick_invoke(bContext *C, wmOperator *op, const wmE
 
 	/* return warning! */
 	if (unified_findnearest(&vc, &basact, &eve, &eed, &efa) == 0) {
-		WM_event_add_notifier(C, NC_GEOM | ND_SELECT, basact->object->data);
-
 		return OPERATOR_CANCELLED;
 	}
 	ED_view3d_viewcontext_init_object(&vc, basact->object);



More information about the Bf-blender-cvs mailing list