[Bf-blender-cvs] [411a7814919] master: Depsgraph: Silence obviously noisy relations build errors

Sergey Sharybin noreply at git.blender.org
Fri Mar 2 16:36:29 CET 2018


Commit: 411a781491954c226ae1f91a8b2735328d85258e
Author: Sergey Sharybin
Date:   Fri Mar 2 15:50:28 2018 +0100
Branches: master
https://developer.blender.org/rB411a781491954c226ae1f91a8b2735328d85258e

Depsgraph: Silence obviously noisy relations build errors

Those were happening for drivers which points to invalid drivers, and those
drivers will have their own dedicated error prints.

===================================================================

M	source/blender/depsgraph/intern/builder/deg_builder_relations.cc

===================================================================

diff --git a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
index 0d85b1dfc93..914c8ef33db 100644
--- a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
+++ b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
@@ -1126,7 +1126,16 @@ void DepsgraphRelationBuilder::build_driver_data(ID *id, FCurve *fcu)
 	}
 	else {
 		RNAPathKey target_key(id, rna_path);
-		add_relation(driver_key, target_key, "Driver -> Target");
+		if (RNA_pointer_is_null(&target_key.ptr)) {
+			/* TODO(sergey): This would only mean that driver is broken.
+			 * so we can't create relation anyway. However, we need to avoid
+			 * adding drivers which are known to be buggy to a dependency
+			 * graph, in order to save computational power.
+			 */
+		}
+		else {
+			add_relation(driver_key, target_key, "Driver -> Target");
+		}
 	}
 }



More information about the Bf-blender-cvs mailing list