[Bf-blender-cvs] [274bde23fb5] master: CMake: enable WITH_ASSERT_ABORT by default

Campbell Barton noreply at git.blender.org
Thu Jun 28 10:49:54 CEST 2018


Commit: 274bde23fb57c014af727fb787c6e8a3342f6240
Author: Campbell Barton
Date:   Thu Jun 28 10:48:06 2018 +0200
Branches: master
https://developer.blender.org/rB274bde23fb57c014af727fb787c6e8a3342f6240

CMake: enable WITH_ASSERT_ABORT by default

Assert from BLI_assert by default in debug builds
(instead of just printing a warning).

Some developers ignored this, causing errors for others.
Better debug builds cause hard error so code isn't ignored.

Disabling is still useful when bisecting or testing outdated code.

===================================================================

M	CMakeLists.txt

===================================================================

diff --git a/CMakeLists.txt b/CMakeLists.txt
index d1b35b1c562..46d91286467 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -444,7 +444,7 @@ mark_as_advanced(WITH_MEM_VALGRIND)
 option(WITH_CXX_GUARDEDALLOC "Enable GuardedAlloc for C++ memory allocation tracking (only enable for development)" OFF)
 mark_as_advanced(WITH_CXX_GUARDEDALLOC)
 
-option(WITH_ASSERT_ABORT "Call abort() when raising an assertion through BLI_assert()" OFF)
+option(WITH_ASSERT_ABORT "Call abort() when raising an assertion through BLI_assert()" ON)
 mark_as_advanced(WITH_ASSERT_ABORT)
 
 option(WITH_BOOST					"Enable features depending on boost" ON)



More information about the Bf-blender-cvs mailing list