[Bf-blender-cvs] [56fd8978a5d] temp-eeveelightcache: Object Mode: Remove cubemap lightprobes outline

Clément Foucault noreply at git.blender.org
Fri Jun 22 17:46:36 CEST 2018


Commit: 56fd8978a5de36e7155ccac9b0d5617968390055
Author: Clément Foucault
Date:   Thu Jun 21 18:47:51 2018 +0200
Branches: temp-eeveelightcache
https://developer.blender.org/rB56fd8978a5de36e7155ccac9b0d5617968390055

Object Mode: Remove cubemap lightprobes outline

This is because the display code now differs and the outline does not match.
This commit make them uselectable by their display shape (the sphere).

I will revisit this latter.

===================================================================

M	source/blender/draw/modes/object_mode.c

===================================================================

diff --git a/source/blender/draw/modes/object_mode.c b/source/blender/draw/modes/object_mode.c
index 56d4198ba11..b2a57ff8060 100644
--- a/source/blender/draw/modes/object_mode.c
+++ b/source/blender/draw/modes/object_mode.c
@@ -1779,6 +1779,9 @@ static void DRW_shgroup_lightprobe(OBJECT_StorageList *stl, OBJECT_PassList *psl
 			copy_v3_v3(prb_data->probe_cube_mat[3], ob->obmat[3]);
 
 			DRWShadingGroup *grp = shgroup_theme_id_to_probe_cube_outline_shgrp(stl, theme_id);
+			/* TODO remove or change the drawing of the cube probes. Theses line draws nothing on purpose
+			 * to keep the call ids correct. */
+			zero_m4(prb_data->probe_cube_mat);
 			DRW_shgroup_call_dynamic_add(grp, call_id, &prb_data->draw_size, prb_data->probe_cube_mat);
 		}
 		else {



More information about the Bf-blender-cvs mailing list