[Bf-blender-cvs] [17ee4836aba] blender2.8: Fix: Remove UI_BLOCK_MOVEMOUSE_QUIT from popovers

Joshua Leung noreply at git.blender.org
Mon Jun 11 16:49:52 CEST 2018

Commit: 17ee4836aba26934e2bb93b27bc77d4b7293133d
Author: Joshua Leung
Date:   Tue Jun 12 02:48:59 2018 +1200
Branches: blender2.8

Fix: Remove UI_BLOCK_MOVEMOUSE_QUIT from popovers

This was causing driver editing popovers to just keep disappearing
whenever you accidentally moved the mouse away, making the popovers
there nearly useless.

After testing with the other popovers we have in other places, I don't
really see why we needed this flag enabled in the first place. You can
still switch between popovers in the topbar by mousing over the others,
and if you want to dismiss without clicking to escape, you can go over a
standard menu instead OR just move back towards the button that spawned it.

Let's just test this out for a while and see how it goes. Maybe we don't
need a more invasive solution here...


M	source/blender/editors/interface/interface_region_popover.c


diff --git a/source/blender/editors/interface/interface_region_popover.c b/source/blender/editors/interface/interface_region_popover.c
index c681cfe776f..e769d367b45 100644
--- a/source/blender/editors/interface/interface_region_popover.c
+++ b/source/blender/editors/interface/interface_region_popover.c
@@ -135,7 +135,7 @@ static uiBlock *ui_block_func_POPOVER(bContext *C, uiPopupBlockHandle *handle, v
 	UI_block_region_set(block, handle->region);
 	UI_block_layout_resolve(block, &width, &height);
+	UI_block_flag_enable(block, UI_BLOCK_KEEP_OPEN | UI_BLOCK_POPOVER);
 	if (pup->is_once) {
 		UI_block_flag_enable(block, UI_BLOCK_POPOVER_ONCE);

More information about the Bf-blender-cvs mailing list