[Bf-blender-cvs] [cfc1ddeff71] master: GHOST/X11: Xinput/XIM support caused double key-up

Campbell Barton noreply at git.blender.org
Thu Jun 7 20:35:30 CEST 2018


Commit: cfc1ddeff71570d702fc0c1c79d36249086849b9
Author: Campbell Barton
Date:   Thu Jun 7 20:32:51 2018 +0200
Branches: master
https://developer.blender.org/rBcfc1ddeff71570d702fc0c1c79d36249086849b9

GHOST/X11: Xinput/XIM support caused double key-up

All keyboard events were sending double key events (including modifiers)
when xinput was enabled with gnome (causing much confusion!).

I cant test if XIM works,
but this isn't useful to send double events, so disabling for now.

===================================================================

M	intern/ghost/intern/GHOST_SystemX11.cpp

===================================================================

diff --git a/intern/ghost/intern/GHOST_SystemX11.cpp b/intern/ghost/intern/GHOST_SystemX11.cpp
index 93a9f3589f4..62befc2f227 100644
--- a/intern/ghost/intern/GHOST_SystemX11.cpp
+++ b/intern/ghost/intern/GHOST_SystemX11.cpp
@@ -571,10 +571,8 @@ processEvents(
 			}
 
 			/* dispatch event to XIM server */
-			if ((XFilterEvent(&xevent, (Window)NULL) == True) && (xevent.type != KeyRelease)) {
-				/* do nothing now, the event is consumed by XIM.
-				 * however, KeyRelease event should be processed
-				 * here, otherwise modifiers remain activated.   */
+			if ((XFilterEvent(&xevent, (Window)NULL) == True)) {
+				/* do nothing now, the event is consumed by XIM. */
 				continue;
 			}
 #endif



More information about the Bf-blender-cvs mailing list