[Bf-blender-cvs] [0e2bc1a4ac0] blender2.8: Make object_update comment about lack of ID even more clear

Dalai Felinto noreply at git.blender.org
Fri Jan 26 12:17:12 CET 2018


Commit: 0e2bc1a4ac01465b935511b9ad65d47186ade649
Author: Dalai Felinto
Date:   Fri Jan 26 09:15:56 2018 -0200
Branches: blender2.8
https://developer.blender.org/rB0e2bc1a4ac01465b935511b9ad65d47186ade649

Make object_update comment about lack of ID even more clear

===================================================================

M	source/blender/blenkernel/intern/object_update.c

===================================================================

diff --git a/source/blender/blenkernel/intern/object_update.c b/source/blender/blenkernel/intern/object_update.c
index d97fba5cb3b..bc183ba95a6 100644
--- a/source/blender/blenkernel/intern/object_update.c
+++ b/source/blender/blenkernel/intern/object_update.c
@@ -438,10 +438,14 @@ void BKE_object_eval_flush_base_flags(const EvaluationContext *UNUSED(eval_ctx),
                                       Object *object, Base *base, bool is_from_set)
 {
 	DEBUG_PRINT("%s on %s (%p)\n", __func__, object->id.name, object);
+
 	/* Make sure we have the base collection settings is already populated.
-	 * This will fail when BKE_layer_eval_layer_collection_pre hasn't run yet
-	 * Which usually means a missing call to DEG_id_tag_update(). */
+	 * This will fail when BKE_layer_eval_layer_collection_pre hasn't run yet.
+	 *
+	 * Which usually means a missing call to DEG_id_tag_update(id, DEG_TAG_BASE_FLAGS_UPDATE).
+	 * Either of the entire scene, or of the newly added objects.*/
 	BLI_assert(!BLI_listbase_is_empty(&base->collection_properties->data.group));
+
 	/* Copy flags and settings from base. */
 	object->base_flag = base->flag;
 	if (is_from_set) {



More information about the Bf-blender-cvs mailing list