[Bf-blender-cvs] [a08e5d86955] soc-2017-normal-tools: Cleanup: do not use 'split_angle' name for a var which is a cosine.
Bastien Montagne
noreply at git.blender.org
Tue Feb 20 15:08:06 CET 2018
Commit: a08e5d86955b47bed3de0cce9ae1e1c6ea14c3ff
Author: Bastien Montagne
Date: Tue Feb 20 12:57:52 2018 +0100
Branches: soc-2017-normal-tools
https://developer.blender.org/rBa08e5d86955b47bed3de0cce9ae1e1c6ea14c3ff
Cleanup: do not use 'split_angle' name for a var which is a cosine.
This is confusing (and has to be fixed in master code as well).
===================================================================
M source/blender/blenkernel/intern/editmesh.c
===================================================================
diff --git a/source/blender/blenkernel/intern/editmesh.c b/source/blender/blenkernel/intern/editmesh.c
index a0205a828e3..f67fe903c8b 100644
--- a/source/blender/blenkernel/intern/editmesh.c
+++ b/source/blender/blenkernel/intern/editmesh.c
@@ -269,8 +269,7 @@ void BKE_editmesh_lnorspace_update(BMEditMesh *em)
{
BMesh *bm = em->bm;
if (bm->lnor_spacearr == NULL) {
- float split_angle = ((Mesh *)em->ob->data)->smoothresh;
- split_angle = cosf(split_angle);
+ const float split_angle_cos = cosf(((Mesh *)em->ob->data)->smoothresh);
BMEdge *e;
BMIter eiter;
@@ -280,7 +279,7 @@ void BKE_editmesh_lnorspace_update(BMEditMesh *em)
const float *no_1 = l_1->f->no;
const float *no_2 = l_2->f->no;
- if (dot_v3v3(no_1, no_2) < split_angle && BM_elem_flag_test(e, BM_ELEM_SMOOTH)) {
+ if (dot_v3v3(no_1, no_2) < split_angle_cos && BM_elem_flag_test(e, BM_ELEM_SMOOTH)) {
BM_elem_flag_disable(e, BM_ELEM_SMOOTH);
}
}
More information about the Bf-blender-cvs
mailing list