[Bf-blender-cvs] [3071d67c3ae] blender2.8: UI: fix glitch redrawing after redo panel collapse

Campbell Barton noreply at git.blender.org
Thu Aug 30 10:53:40 CEST 2018


Commit: 3071d67c3aeba4e5bec73f88b24eed972424dae0
Author: Campbell Barton
Date:   Thu Aug 30 18:58:18 2018 +1000
Branches: blender2.8
https://developer.blender.org/rB3071d67c3aeba4e5bec73f88b24eed972424dae0

UI: fix glitch redrawing after redo panel collapse

===================================================================

M	source/blender/editors/interface/interface_panel.c

===================================================================

diff --git a/source/blender/editors/interface/interface_panel.c b/source/blender/editors/interface/interface_panel.c
index aa67d58fd57..cb5c104e638 100644
--- a/source/blender/editors/interface/interface_panel.c
+++ b/source/blender/editors/interface/interface_panel.c
@@ -134,7 +134,7 @@ static int panel_aligned(ScrArea *sa, ARegion *ar)
 		return BUT_VERTICAL;
 	else if (sa->spacetype == SPACE_IMAGE && ar->regiontype == RGN_TYPE_PREVIEW)
 		return BUT_VERTICAL;
-	else if (ELEM(ar->regiontype, RGN_TYPE_UI, RGN_TYPE_TOOLS, RGN_TYPE_TOOL_PROPS))
+	else if (ELEM(ar->regiontype, RGN_TYPE_UI, RGN_TYPE_TOOLS, RGN_TYPE_TOOL_PROPS, RGN_TYPE_HUD))
 		return BUT_VERTICAL;
 
 	return 0;
@@ -1563,10 +1563,15 @@ static void ui_handle_panel_header(const bContext *C, uiBlock *block, int mx, in
 			}
 		}
 
-		if (align)
+		if (align) {
 			panel_activate_state(C, block->panel, PANEL_STATE_ANIMATION);
-		else
+		}
+		else {
+			/* FIXME: this doesn't update the panel drawing, assert to avoid debugging why this is.
+			 * We could fix this in the future if it's ever needed. */
+			BLI_assert(0);
 			ED_region_tag_redraw(ar);
+		}
 	}
 	else if (show_drag && BLI_rctf_isect_x(&rect_drag, mx)) {
 		/* XXX, for now don't allow dragging in floating windows yet. */



More information about the Bf-blender-cvs mailing list