[Bf-blender-cvs] [a88a8528f11] blender2.8: Draw manager: Fix wrong engine type used for view update

Sergey Sharybin noreply at git.blender.org
Mon Apr 30 12:20:34 CEST 2018


Commit: a88a8528f11a8c3d9ee3cf999a92768940abe2ee
Author: Sergey Sharybin
Date:   Mon Apr 30 12:17:42 2018 +0200
Branches: blender2.8
https://developer.blender.org/rBa88a8528f11a8c3d9ee3cf999a92768940abe2ee

Draw manager: Fix wrong engine type used for view update

Was causing temporal sampling artifacts when scene is set to Cycles
and viewport is set to Eevee. Visually was looking like ghosting or
motion blur when moving objects.

===================================================================

M	source/blender/editors/render/render_update.c

===================================================================

diff --git a/source/blender/editors/render/render_update.c b/source/blender/editors/render/render_update.c
index 1864cb0af6a..7da571f1941 100644
--- a/source/blender/editors/render/render_update.c
+++ b/source/blender/editors/render/render_update.c
@@ -120,9 +120,10 @@ void ED_render_scene_update(const DEGEditorUpdateContext *update_ctx, int update
 		CTX_wm_window_set(C, win);
 
 		for (sa = sc->areabase.first; sa; sa = sa->next) {
-			if (sa->spacetype != SPACE_VIEW3D)
+			if (sa->spacetype != SPACE_VIEW3D) {
 				continue;
-
+			}
+			View3D *v3d = sa->spacedata.first;
 			for (ar = sa->regionbase.first; ar; ar = ar->next) {
 				if (ar->regiontype != RGN_TYPE_WINDOW) {
 					continue;
@@ -143,7 +144,8 @@ void ED_render_scene_update(const DEGEditorUpdateContext *update_ctx, int update
 
 				}
 				else {
-					RenderEngineType *engine_type = RE_engines_find(scene->r.engine);
+					RenderEngineType *engine_type =
+					        ED_view3d_engine_type(scene, v3d->drawtype);
 					if (updated) {
 						DRW_notify_view_update(
 						        (&(DRWUpdateContext){



More information about the Bf-blender-cvs mailing list