[Bf-blender-cvs] [6e099728482] temp-modifier-rm-cddm: Added note about potential crash in add_orco_dm()

Sybren A. Stüvel noreply at git.blender.org
Wed Apr 25 10:08:28 CEST 2018


Commit: 6e0997284827806d85b0930136b690319a2c6e20
Author: Sybren A. Stüvel
Date:   Wed Apr 25 09:53:32 2018 +0200
Branches: temp-modifier-rm-cddm
https://developer.blender.org/rB6e0997284827806d85b0930136b690319a2c6e20

Added note about potential crash in add_orco_dm()

===================================================================

M	source/blender/blenkernel/intern/DerivedMesh.c

===================================================================

diff --git a/source/blender/blenkernel/intern/DerivedMesh.c b/source/blender/blenkernel/intern/DerivedMesh.c
index b28beaa5b99..9058fd1546a 100644
--- a/source/blender/blenkernel/intern/DerivedMesh.c
+++ b/source/blender/blenkernel/intern/DerivedMesh.c
@@ -1282,8 +1282,11 @@ static void add_orco_dm(
 		else
 			dm->getVertCos(dm, orco);
 	}
-	else
+	else {
+		/* TODO(sybren): totvert should potentially change here, as ob->data
+		 * or em may have a different number of vertices than dm. */
 		orco = get_orco_coords_dm(ob, em, layer, &free);
+	}
 
 	if (orco) {
 		if (layer == CD_ORCO)



More information about the Bf-blender-cvs mailing list