[Bf-blender-cvs] [4f6196a0413] master: Fix: Border select for GPencil keyframes was including those in the "datablock" channels even though those weren't visible

Joshua Leung noreply at git.blender.org
Sun Sep 3 02:51:08 CEST 2017


Commit: 4f6196a04131a462a1f0712ac7d0f9eb6fb0c150
Author: Joshua Leung
Date:   Sun Sep 3 12:40:49 2017 +1200
Branches: master
https://developer.blender.org/rB4f6196a04131a462a1f0712ac7d0f9eb6fb0c150

Fix: Border select for GPencil keyframes was including those in the "datablock" channels even though those weren't visible

This meant that it was easy to accidentally select too many keyframes

===================================================================

M	source/blender/editors/space_action/action_select.c

===================================================================

diff --git a/source/blender/editors/space_action/action_select.c b/source/blender/editors/space_action/action_select.c
index 553be0ad290..17edbc6cc1d 100644
--- a/source/blender/editors/space_action/action_select.c
+++ b/source/blender/editors/space_action/action_select.c
@@ -262,6 +262,7 @@ static void borderselect_action(bAnimContext *ac, const rcti rect, short mode, s
 		{
 			/* loop over data selecting */
 			switch (ale->type) {
+#if 0 /* XXXX: Keyframes are not currently shown here */
 				case ANIMTYPE_GPDATABLOCK:
 				{
 					bGPdata *gpd = ale->data;
@@ -271,6 +272,7 @@ static void borderselect_action(bAnimContext *ac, const rcti rect, short mode, s
 					}
 					break;
 				}
+#endif
 				case ANIMTYPE_GPLAYER:
 					ED_gplayer_frames_select_border(ale->data, rectf.xmin, rectf.xmax, selectmode);
 					break;



More information about the Bf-blender-cvs mailing list