[Bf-blender-cvs] [bb1475053e6] greasepencil-object: Fix: GP array modifier's "count" property should have a lower "sane" limit

Joshua Leung noreply at git.blender.org
Sat Nov 4 05:48:30 CET 2017


Commit: bb1475053e69d60ed1687dace48182b56deb26d3
Author: Joshua Leung
Date:   Fri Nov 3 14:10:26 2017 +1300
Branches: greasepencil-object
https://developer.blender.org/rBbb1475053e69d60ed1687dace48182b56deb26d3

Fix: GP array modifier's "count" property should have a lower "sane" limit

Previously, the upper bound for dragging in the UI was effectively unlimited.
This has the unfortunate consequence of causing hard resets (out of bounds/memory)
as I found out last night while testing this.

===================================================================

M	source/blender/makesrna/intern/rna_modifier.c

===================================================================

diff --git a/source/blender/makesrna/intern/rna_modifier.c b/source/blender/makesrna/intern/rna_modifier.c
index bda671a6d07..a4e910c9d82 100644
--- a/source/blender/makesrna/intern/rna_modifier.c
+++ b/source/blender/makesrna/intern/rna_modifier.c
@@ -5263,6 +5263,7 @@ static void rna_def_modifier_gpencilarray(BlenderRNA *brna)
 
 	prop = RNA_def_property(srna, "count", PROP_INT, PROP_XYZ);
 	RNA_def_property_range(prop, 1, INT_MAX);
+	RNA_def_property_ui_range(prop, 1, 1000, 1, -1);
 	RNA_def_property_ui_text(prop, "Count", "Number of items");
 	RNA_def_property_update(prop, 0, "rna_Modifier_gpencil_update");



More information about the Bf-blender-cvs mailing list