[Bf-blender-cvs] [cc9eb7b26c2] greasepencil-object: Restored manual gpencil_batch_cache_dirty() call when adding modifiers

Joshua Leung noreply at git.blender.org
Sat Nov 4 05:48:27 CET 2017


Commit: cc9eb7b26c2233f040e643ae6ec235d683fcdee8
Author: Joshua Leung
Date:   Fri Nov 3 01:15:21 2017 +1300
Branches: greasepencil-object
https://developer.blender.org/rBcc9eb7b26c2233f040e643ae6ec235d683fcdee8

Restored manual gpencil_batch_cache_dirty() call when adding modifiers

There are too many problems leaving it out, even if in theory the depsgraph
calls should be taking care of it.

===================================================================

M	source/blender/editors/object/object_modifier.c

===================================================================

diff --git a/source/blender/editors/object/object_modifier.c b/source/blender/editors/object/object_modifier.c
index dd4b5e0eda0..6526744e293 100644
--- a/source/blender/editors/object/object_modifier.c
+++ b/source/blender/editors/object/object_modifier.c
@@ -174,11 +174,10 @@ ModifierData *ED_object_modifier_add(ReportList *reports, Main *bmain, Scene *sc
 		}
 	}
 
-#if 0 // XXX: Review this (aligorith)
 	if (ob->type == OB_GPENCIL) {
+		/* FIXME: Shouldn't the depsgraph tagging handle this? */
 		BKE_gpencil_batch_cache_dirty(ob->data);
 	}
-#endif
 
 	DEG_id_tag_update(&ob->id, OB_RECALC_DATA);
 	DEG_relations_tag_update(bmain);



More information about the Bf-blender-cvs mailing list