[Bf-blender-cvs] [6deaab207c2] blender2.8: remove old PBVH VertexBufferFormat struct

Mike Erwin noreply at git.blender.org
Sat May 13 05:40:18 CEST 2017


Commit: 6deaab207c25e7f8728696a3e57902c6a24abbbb
Author: Mike Erwin
Date:   Fri May 12 23:32:37 2017 -0400
Branches: blender2.8
https://developer.blender.org/rB6deaab207c25e7f8728696a3e57902c6a24abbbb

remove old PBVH VertexBufferFormat struct

Follow-up to 0722e41f9ea450be014d667417ff903510be2770 which removed all uses of this struct. Gawain VertexFormat auto aligns attributes as described in @nicholasbishop's performance note.

===================================================================

M	source/blender/gpu/intern/gpu_buffers.c

===================================================================

diff --git a/source/blender/gpu/intern/gpu_buffers.c b/source/blender/gpu/intern/gpu_buffers.c
index 81466d156ee..b04cd580e6c 100644
--- a/source/blender/gpu/intern/gpu_buffers.c
+++ b/source/blender/gpu/intern/gpu_buffers.c
@@ -949,19 +949,6 @@ void GPU_buffer_draw_elements(GPUBuffer *UNUSED(elements), unsigned int mode, in
 /* XXX: the rest of the code in this file is used for optimized PBVH
  * drawing and doesn't interact at all with the buffer code above */
 
-/* Convenience struct for building the VBO. */
-typedef struct {
-	float co[3];
-	short no[3];
-
-	/* inserting this to align the 'color' field to a four-byte
-	 * boundary; drastically increases viewport performance on my
-	 * drivers (Gallium/Radeon) --nicholasbishop */
-	char pad[2];
-	
-	unsigned char color[3];
-} VertexBufferFormat;
-
 struct GPU_PBVH_Buffers {
 	ElementList *index_buf, *index_buf_fast;
 	VertexBuffer *vert_buf;




More information about the Bf-blender-cvs mailing list