[Bf-blender-cvs] [2e8398c095] master: Get rid of `BLI_task_pool_stop()`.

Bastien Montagne noreply at git.blender.org
Fri Mar 3 17:18:59 CET 2017


Commit: 2e8398c0956544e2c316ef7ec6263f78d1fbb705
Author: Bastien Montagne
Date:   Fri Mar 3 17:16:39 2017 +0100
Branches: master
https://developer.blender.org/rB2e8398c0956544e2c316ef7ec6263f78d1fbb705

Get rid of `BLI_task_pool_stop()`.

Comments said that function was supposed to 'stop worker threads', but
it absolutely did not do anything like that, was merely wiping out TODO
queue of tasks from given pool (kind of subset of what
`BLI_task_pool_cancel()` does).

Misleading, and currently useless, we can always add it back if we need
it some day, but for now we try to simplify that area.

===================================================================

M	source/blender/blenlib/intern/task.c

===================================================================

diff --git a/source/blender/blenlib/intern/task.c b/source/blender/blenlib/intern/task.c
index 359360d59c..91e821a8f1 100644
--- a/source/blender/blenlib/intern/task.c
+++ b/source/blender/blenlib/intern/task.c
@@ -708,13 +708,6 @@ void BLI_task_pool_cancel(TaskPool *pool)
 	pool->do_cancel = false;
 }
 
-void BLI_task_pool_stop(TaskPool *pool)
-{
-	task_scheduler_clear(pool->scheduler, pool);
-
-	BLI_assert(pool->num == 0);
-}
-
 bool BLI_task_pool_canceled(TaskPool *pool)
 {
 	return pool->do_cancel;




More information about the Bf-blender-cvs mailing list