[Bf-blender-cvs] [1f933c94a76] master: Cycles: Fix comparison in principled BSDF

Mai Lavelle noreply at git.blender.org
Wed Jul 12 05:44:06 CEST 2017


Commit: 1f933c94a76e546de3d8fe43d74977b2fd15ff14
Author: Mai Lavelle
Date:   Tue Jul 11 23:41:22 2017 -0400
Branches: master
https://developer.blender.org/rB1f933c94a76e546de3d8fe43d74977b2fd15ff14

Cycles: Fix comparison in principled BSDF

Could have lead to black pixels.

===================================================================

M	intern/cycles/kernel/svm/svm_closure.h

===================================================================

diff --git a/intern/cycles/kernel/svm/svm_closure.h b/intern/cycles/kernel/svm/svm_closure.h
index 9578fcf2687..7704aa545c8 100644
--- a/intern/cycles/kernel/svm/svm_closure.h
+++ b/intern/cycles/kernel/svm/svm_closure.h
@@ -159,7 +159,7 @@ ccl_device void svm_node_closure_bsdf(KernelGlobals *kg, ShaderData *sd, float *
 
 			/* diffuse */
 			if(fabsf(average(mixed_ss_base_color)) > CLOSURE_WEIGHT_CUTOFF) {
-				if(subsurface < CLOSURE_WEIGHT_CUTOFF && diffuse_weight > CLOSURE_WEIGHT_CUTOFF) {
+				if(subsurface <= CLOSURE_WEIGHT_CUTOFF && diffuse_weight > CLOSURE_WEIGHT_CUTOFF) {
 					float3 diff_weight = weight * base_color * diffuse_weight;
 
 					PrincipledDiffuseBsdf *bsdf = (PrincipledDiffuseBsdf*)bsdf_alloc(sd, sizeof(PrincipledDiffuseBsdf), diff_weight);




More information about the Bf-blender-cvs mailing list