[Bf-blender-cvs] [6d36e033ba] master: Cycles: Remove using namespace hell

Sergey Sharybin noreply at git.blender.org
Thu Jan 19 14:53:25 CET 2017


Commit: 6d36e033ba4051362a3a4985989e9d360e3888a8
Author: Sergey Sharybin
Date:   Thu Jan 19 14:24:14 2017 +0100
Branches: master
https://developer.blender.org/rB6d36e033ba4051362a3a4985989e9d360e3888a8

Cycles: Remove using namespace hell

Please NEVER EVER use such a statement, it's only causing HUGE
issues. What is even worse: it's not always possible to immediately
see that the hell is coming from such a statement.

There is still some statements in the existing code, will leave
those for a later cleanup.

===================================================================

M	intern/cycles/render/mesh_subdivision.cpp
M	intern/cycles/util/util_boundbox.h

===================================================================

diff --git a/intern/cycles/render/mesh_subdivision.cpp b/intern/cycles/render/mesh_subdivision.cpp
index 913c3c74b4..57c76a9f1c 100644
--- a/intern/cycles/render/mesh_subdivision.cpp
+++ b/intern/cycles/render/mesh_subdivision.cpp
@@ -92,7 +92,7 @@ namespace Far {
 
 			if(vert_edges.size() == 2) {
 				float sharpness = refiner.getLevel(0).getEdgeSharpness(vert_edges[0]);
-				sharpness = min(sharpness, refiner.getLevel(0).getEdgeSharpness(vert_edges[1]));
+				sharpness = ccl::min(sharpness, refiner.getLevel(0).getEdgeSharpness(vert_edges[1]));
 
 				setBaseVertexSharpness(refiner, i, sharpness);
 			}
diff --git a/intern/cycles/util/util_boundbox.h b/intern/cycles/util/util_boundbox.h
index 599222da9c..dfe4977aef 100644
--- a/intern/cycles/util/util_boundbox.h
+++ b/intern/cycles/util/util_boundbox.h
@@ -25,8 +25,6 @@
 #include "util_transform.h"
 #include "util_types.h"
 
-using namespace std;
-
 CCL_NAMESPACE_BEGIN
 
 /* 3D BoundBox */




More information about the Bf-blender-cvs mailing list