[Bf-blender-cvs] [fd4728c85a] master: BMesh: Use angle_signed_on_axis_v3v3v3_v3

Campbell Barton noreply at git.blender.org
Wed Jan 18 22:01:24 CET 2017


Commit: fd4728c85a6e3a7041f6ff62d73b15e432b84f92
Author: Campbell Barton
Date:   Thu Jan 19 07:59:32 2017 +1100
Branches: master
https://developer.blender.org/rBfd4728c85a6e3a7041f6ff62d73b15e432b84f92

BMesh: Use angle_signed_on_axis_v3v3v3_v3

===================================================================

M	source/blender/bmesh/intern/bmesh_construct.c

===================================================================

diff --git a/source/blender/bmesh/intern/bmesh_construct.c b/source/blender/bmesh/intern/bmesh_construct.c
index 132a7ccd4f..af7ef01da7 100644
--- a/source/blender/bmesh/intern/bmesh_construct.c
+++ b/source/blender/bmesh/intern/bmesh_construct.c
@@ -470,25 +470,7 @@ BMFace *BM_face_create_ngon_vcloud(
 
 	/* now calculate every points angle around the normal (signed) */
 	for (i = 0; i < len; i++) {
-		float co[3];
-		float proj_vec[3];
-		float angle;
-
-		/* center relative vec */
-		sub_v3_v3v3(co, vert_arr[i]->co, cent);
-
-		/* align to plane */
-		project_v3_v3v3(proj_vec, co, nor);
-		sub_v3_v3(co, proj_vec);
-
-		/* now 'co' is valid - we can compare its angle against the far vec */
-		angle = angle_v3v3(far_vec, co);
-
-		if (dot_v3v3(co, sign_vec) < 0.0f) {
-			angle = -angle;
-		}
-
-		vang[i].sort_value = angle;
+		vang[i].sort_value = angle_signed_on_axis_v3v3v3_v3(far, cent, vert_arr[i]->co, nor);
 		vang[i].data = i;
 	}




More information about the Bf-blender-cvs mailing list