[Bf-blender-cvs] [75cc33fa20] master: Fix Cycles still saving render output when error happened

Sergey Sharybin noreply at git.blender.org
Wed Feb 22 13:08:19 CET 2017


Commit: 75cc33fa20457695d33e90886e8802c28fd96c2a
Author: Sergey Sharybin
Date:   Wed Feb 22 13:06:24 2017 +0100
Branches: master
https://developer.blender.org/rB75cc33fa20457695d33e90886e8802c28fd96c2a

Fix Cycles still saving render output when error happened

This was fixed ages ago for the interface case but not for the
command line. The thing here is that currently external engines
are relying on reports system to indicate that error happened
so suppressing reports storage in the background mode prevented
render pipeline from detecting errors happened.

This is all weak and i don't like it, but this is better than
delivering black frames from the farm.

===================================================================

M	source/creator/creator_args.c

===================================================================

diff --git a/source/creator/creator_args.c b/source/creator/creator_args.c
index 27579e58db..77ca055dce 100644
--- a/source/creator/creator_args.c
+++ b/source/creator/creator_args.c
@@ -1364,7 +1364,7 @@ static int arg_handle_render_frame(int argc, const char **argv, void *data)
 
 			re = RE_NewRender(scene->id.name);
 			BLI_begin_threaded_malloc();
-			BKE_reports_init(&reports, RPT_PRINT);
+			BKE_reports_init(&reports, RPT_STORE);
 
 			RE_SetReports(re, &reports);
 			for (int i = 0; i < frames_range_len; i++) {
@@ -1379,6 +1379,7 @@ static int arg_handle_render_frame(int argc, const char **argv, void *data)
 				}
 			}
 			RE_SetReports(re, NULL);
+			BKE_reports_clear(&reports);
 			BLI_end_threaded_malloc();
 			MEM_freeN(frame_range_arr);
 			return 1;




More information about the Bf-blender-cvs mailing list