[Bf-blender-cvs] [0b4a9caf51] master: Forgotten in committee ddf99214dc06 In obect mode, the rotation matrix need to be restored to the initial value if a snap point is not found

Germano Cavalcante noreply at git.blender.org
Fri Feb 3 16:57:19 CET 2017


Commit: 0b4a9caf51244fb85efea9d2fb41335f87cda762
Author: Germano Cavalcante
Date:   Fri Feb 3 12:57:02 2017 -0300
Branches: master
https://developer.blender.org/rB0b4a9caf51244fb85efea9d2fb41335f87cda762

Forgotten in committee ddf99214dc06
In obect mode, the rotation matrix need to be restored to the initial value if a snap point is not found

===================================================================

M	source/blender/editors/transform/transform.c

===================================================================

diff --git a/source/blender/editors/transform/transform.c b/source/blender/editors/transform/transform.c
index 5929aba48a..1916f9b4da 100644
--- a/source/blender/editors/transform/transform.c
+++ b/source/blender/editors/transform/transform.c
@@ -4346,10 +4346,10 @@ static void applyTranslationValue(TransInfo *t, const float vec[3])
 	TransData *td = t->data;
 	float tvec[3];
 
-	/* you only need to "apply_snap_align_rotation" when a snap point is found (t->tsnap.status & POINT_INIT)
+	/* The ideal would be "apply_snap_align_rotation" only when a snap point is found
 	 * so, maybe inside this function is not the best place to apply this rotation.
 	 * but you need "handle snapping rotation before doing the translation" (really?) */
-	const bool apply_snap_align_rotation = usingSnappingNormal(t) && (t->tsnap.status & POINT_INIT);
+	const bool apply_snap_align_rotation = usingSnappingNormal(t);// && (t->tsnap.status & POINT_INIT);
 	float pivot[3];
 	if (apply_snap_align_rotation) {
 		copy_v3_v3(pivot, t->tsnap.snapTarget);




More information about the Bf-blender-cvs mailing list