[Bf-blender-cvs] [5f0e305f4ef] temp-sybren-alembic-customprops-read: Some clarifications

Sybren A. Stüvel noreply at git.blender.org
Thu Dec 7 10:36:32 CET 2017


Commit: 5f0e305f4ef58ad53b6e3aa73e15f20cd2faa1b7
Author: Sybren A. Stüvel
Date:   Mon Nov 13 14:03:47 2017 +0100
Branches: temp-sybren-alembic-customprops-read
https://developer.blender.org/rB5f0e305f4ef58ad53b6e3aa73e15f20cd2faa1b7

Some clarifications

===================================================================

M	source/blender/alembic/intern/abc_object.cc

===================================================================

diff --git a/source/blender/alembic/intern/abc_object.cc b/source/blender/alembic/intern/abc_object.cc
index e4ccb03c3bc..f03dfc53ba6 100644
--- a/source/blender/alembic/intern/abc_object.cc
+++ b/source/blender/alembic/intern/abc_object.cc
@@ -375,7 +375,10 @@ void AbcObjectReader::decref()
 	BLI_assert(m_refcount >= 0);
 }
 
-/* 'sl' means 'scalar like', a concept of Alembic properties indicating single-valued arrays. */
+/* ************* CUSTOM PROPERTY SUPPORT **********************
+ * Below 'sl' means 'scalar like', a concept of Alembic properties indicating
+ * single-valued arrays. Houdini, Maya, etc. write singleton values as
+ * arrays, so we read them as singleton values as well. */
 template<typename ABCTYPE>
 static IDProperty *read_array_sl_int(const PropertyHeader &header,
                                      ArraySamplePtr val)
@@ -507,7 +510,10 @@ void AbcObjectReader::read_custom_properties_into(ID *id,
 						break;
 					}
 					default:
-						std::cerr << "Custom property " << header.getName() << " is array of data type " << header.getDataType() << "; not supported.\n";
+						std::cerr << "Custom property " << header.getName()
+						          << " is scalar-like array of data type " << header.getDataType()
+						          << "; not supported."
+						          << std::endl;
 						continue;
 				}
 			}



More information about the Bf-blender-cvs mailing list