[Bf-blender-cvs] [6b72d87def0] master: Depsgraph: Remove unused property based update tags

Sergey Sharybin noreply at git.blender.org
Mon Dec 4 14:49:25 CET 2017


Commit: 6b72d87def006c40b168bb702ab48e9d676af50b
Author: Sergey Sharybin
Date:   Mon Dec 4 12:34:25 2017 +0100
Branches: master
https://developer.blender.org/rB6b72d87def006c40b168bb702ab48e9d676af50b

Depsgraph: Remove unused property based update tags

Those are unused, and not clear whether we will ever support this.

Seems to be better having more like "component" tags, would be less magic
involved to guess what exactly is to be tagged.

===================================================================

M	source/blender/depsgraph/DEG_depsgraph.h
M	source/blender/depsgraph/intern/depsgraph_tag.cc

===================================================================

diff --git a/source/blender/depsgraph/DEG_depsgraph.h b/source/blender/depsgraph/DEG_depsgraph.h
index 9349b189e7b..0837f147275 100644
--- a/source/blender/depsgraph/DEG_depsgraph.h
+++ b/source/blender/depsgraph/DEG_depsgraph.h
@@ -111,8 +111,6 @@ void DEG_on_visible_update(struct Main *bmain, const bool do_time);
 void DEG_graph_id_tag_update(struct Main *bmain,
                              Depsgraph *graph,
                              struct ID *id);
-void DEG_graph_data_tag_update(Depsgraph *graph, const struct PointerRNA *ptr);
-void DEG_graph_property_tag_update(Depsgraph *graph, const struct PointerRNA *ptr, const struct PropertyRNA *prop);
 
 /* Tag given ID for an update in all the dependency graphs. */
 void DEG_id_tag_update(struct ID *id, short flag);
diff --git a/source/blender/depsgraph/intern/depsgraph_tag.cc b/source/blender/depsgraph/intern/depsgraph_tag.cc
index 3d63e570eb8..eafb091e53a 100644
--- a/source/blender/depsgraph/intern/depsgraph_tag.cc
+++ b/source/blender/depsgraph/intern/depsgraph_tag.cc
@@ -167,36 +167,6 @@ void DEG_graph_id_tag_update(Main *bmain, Depsgraph *graph, ID *id)
 	}
 }
 
-/* Tag nodes related to a specific piece of data */
-void DEG_graph_data_tag_update(Depsgraph *graph, const PointerRNA *ptr)
-{
-	DEG::Depsgraph *deg_graph = reinterpret_cast<DEG::Depsgraph *>(graph);
-	DEG::DepsNode *node = deg_graph->find_node_from_pointer(ptr, NULL);
-	if (node != NULL) {
-		node->tag_update(deg_graph);
-	}
-	else {
-		printf("Missing node in %s\n", __func__);
-		BLI_assert(!"Shouldn't happens since it'll miss crucial update.");
-	}
-}
-
-/* Tag nodes related to a specific property. */
-void DEG_graph_property_tag_update(Depsgraph *graph,
-                                   const PointerRNA *ptr,
-                                   const PropertyRNA *prop)
-{
-	DEG::Depsgraph *deg_graph = reinterpret_cast<DEG::Depsgraph *>(graph);
-	DEG::DepsNode *node = deg_graph->find_node_from_pointer(ptr, prop);
-	if (node != NULL) {
-		node->tag_update(deg_graph);
-	}
-	else {
-		printf("Missing node in %s\n", __func__);
-		BLI_assert(!"Shouldn't happens since it'll miss crucial update.");
-	}
-}
-
 /* Tag given ID for an update in all the dependency graphs. */
 void DEG_id_tag_update(ID *id, short flag)
 {



More information about the Bf-blender-cvs mailing list