[Bf-blender-cvs] [3e6f5f36434] blender2.8: GraphEdit Handle Drawing: Fix handle-vertex size regression (2.7 -> 2.8)

Joshua Leung noreply at git.blender.org
Wed Aug 2 15:52:18 CEST 2017


Commit: 3e6f5f3643475b69e1ed9b87e5f512f345ec0c94
Author: Joshua Leung
Date:   Thu Aug 3 01:52:07 2017 +1200
Branches: blender2.8
https://developer.blender.org/rB3e6f5f3643475b69e1ed9b87e5f512f345ec0c94

GraphEdit Handle Drawing: Fix handle-vertex size regression (2.7 -> 2.8)

Keyframe handle vertices (the circles on the ends of the handles)
should always be larger than the central vertex. This brings back the
"outer" radius value from the old gluDisk(), and doubles it to get the
necessary diameter, to scale it properly.

TODO's:
- Get rid of all fills inside these circles
- Make the central vertex square-shaped again

===================================================================

M	source/blender/editors/space_graph/graph_draw.c

===================================================================

diff --git a/source/blender/editors/space_graph/graph_draw.c b/source/blender/editors/space_graph/graph_draw.c
index 1739569767e..01dc272ead4 100644
--- a/source/blender/editors/space_graph/graph_draw.c
+++ b/source/blender/editors/space_graph/graph_draw.c
@@ -259,7 +259,7 @@ static void draw_fcurve_handle_vertices(FCurve *fcu, View2D *v2d, bool sel_handl
 	immBindBuiltinProgram(GPU_SHADER_2D_POINT_UNIFORM_SIZE_UNIFORM_COLOR_OUTLINE_AA);
 
 	/* set handle size */
-	immUniform1f("size", (UI_GetThemeValuef(TH_HANDLE_VERTEX_SIZE) + 1.0f) * U.pixelsize);
+	immUniform1f("size", (1.4f * UI_GetThemeValuef(TH_HANDLE_VERTEX_SIZE)) * U.pixelsize);
 	immUniform1f("outlineWidth", 1.0f * U.pixelsize);
 
 	draw_fcurve_selected_handle_vertices(fcu, v2d, false, sel_handle_only, pos);




More information about the Bf-blender-cvs mailing list