[Bf-blender-cvs] [535cf2c7140] blender2.8: Fixup for "always use selection in core"

Dalai Felinto noreply at git.blender.org
Wed Apr 26 11:15:14 CEST 2017


Commit: 535cf2c71409893748c21d00a7da32907fe54622
Author: Dalai Felinto
Date:   Wed Apr 26 11:13:22 2017 +0200
Branches: blender2.8
https://developer.blender.org/rB535cf2c71409893748c21d00a7da32907fe54622

Fixup for "always use selection in core"

In my previous commit [1] I forgot one of the if() calls. Handled it
differently now.

[1] dc1f491a506deafbd80f13b20783e477ef5f99fd

===================================================================

M	source/blender/editors/space_view3d/view3d_view.c

===================================================================

diff --git a/source/blender/editors/space_view3d/view3d_view.c b/source/blender/editors/space_view3d/view3d_view.c
index 3314ae27e47..28ff1231b25 100644
--- a/source/blender/editors/space_view3d/view3d_view.c
+++ b/source/blender/editors/space_view3d/view3d_view.c
@@ -1185,16 +1185,15 @@ int view3d_opengl_select(
 	
 	GPU_select_begin(buffer, bufsize, &rect, gpu_select_mode, 0);
 
-#ifdef WITH_OPENGL_LEGACY
-	if (IS_VIEWPORT_LEGACY(vc->v3d)) {
-		ED_view3d_draw_select_loop(vc, scene, sl, v3d, ar, use_obedit_skip, use_nearest);
+#ifndef WITH_OPENGL_LEGACY
+	if (!IS_VIEWPORT_LEGACY(vc->v3d))
+#endif
+	{
+		DRW_draw_select_loop(vc, graph, scene, sl, v3d, ar, use_obedit_skip, use_nearest, &rect);
 	}
 	else {
-		DRW_draw_select_loop(vc, graph, scene, sl, v3d, ar, use_obedit_skip, use_nearest, &rect);
+		ED_view3d_draw_select_loop(vc, scene, sl, v3d, ar, use_obedit_skip, use_nearest);
 	}
-#else
-	DRW_draw_select_loop(vc, graph, scene, sl, v3d, ar, use_obedit_skip, use_nearest, &rect);
-#endif /* WITH_OPENGL_LEGACY */
 
 	hits = GPU_select_end();
 	
@@ -1202,11 +1201,14 @@ int view3d_opengl_select(
 	if (do_passes) {
 		GPU_select_begin(buffer, bufsize, &rect, GPU_SELECT_NEAREST_SECOND_PASS, hits);
 
-		if (IS_VIEWPORT_LEGACY(vc->v3d)) {
-			ED_view3d_draw_select_loop(vc, scene, sl, v3d, ar, use_obedit_skip, use_nearest);
+#ifndef WITH_OPENGL_LEGACY
+		if (!IS_VIEWPORT_LEGACY(vc->v3d))
+#endif
+		{
+			DRW_draw_select_loop(vc, graph, scene, sl, v3d, ar, use_obedit_skip, use_nearest, &rect);
 		}
 		else {
-			DRW_draw_select_loop(vc, graph, scene, sl, v3d, ar, use_obedit_skip, use_nearest, &rect);
+			ED_view3d_draw_select_loop(vc, scene, sl, v3d, ar, use_obedit_skip, use_nearest);
 		}
 
 		GPU_select_end();




More information about the Bf-blender-cvs mailing list