[Bf-blender-cvs] [0fd53c87ded] master: Alembic export: converted some export params to actual bools

Sybren A. Stüvel noreply at git.blender.org
Wed Apr 19 14:57:16 CEST 2017


Commit: 0fd53c87ded952049a09e45174b7e372e126ed54
Author: Sybren A. Stüvel
Date:   Wed Apr 19 11:43:35 2017 +0200
Branches: master
https://developer.blender.org/rB0fd53c87ded952049a09e45174b7e372e126ed54

Alembic export: converted some export params to actual bools

The variables were interpreted as booleans, and had a 1-bit width. I don't
see a reason to not just use the bool type instead.

===================================================================

M	source/blender/alembic/ABC_alembic.h

===================================================================

diff --git a/source/blender/alembic/ABC_alembic.h b/source/blender/alembic/ABC_alembic.h
index e92d5f2d9f7..df19a836ca3 100644
--- a/source/blender/alembic/ABC_alembic.h
+++ b/source/blender/alembic/ABC_alembic.h
@@ -53,24 +53,26 @@ struct AlembicExportParams {
 	double shutter_open;
 	double shutter_close;
 
-	/* bools */
-	unsigned int selected_only : 1;
-	unsigned int uvs : 1;
-	unsigned int normals : 1;
-	unsigned int vcolors : 1;
-	unsigned int apply_subdiv : 1;
-	unsigned int flatten_hierarchy : 1;
-	unsigned int visible_layers_only : 1;
-	unsigned int renderable_only : 1;
-	unsigned int face_sets : 1;
-	unsigned int use_subdiv_schema : 1;
-	unsigned int packuv : 1;
-	unsigned int triangulate : 1;
+	bool selected_only;
+	bool uvs;
+	bool normals;
+	bool vcolors;
+	bool apply_subdiv;
+	bool flatten_hierarchy;
+	bool visible_layers_only;
+	bool renderable_only;
+	bool face_sets;
+	bool use_subdiv_schema;
+	bool packuv;
+	bool triangulate;
 
 	unsigned int compression_type : 1;
 
+	/* See MOD_TRIANGULATE_NGON_xxx and MOD_TRIANGULATE_QUAD_xxx
+	 * in DNA_modifier_types.h */
 	int quad_method;
 	int ngon_method;
+
 	float global_scale;
 };




More information about the Bf-blender-cvs mailing list