[Bf-blender-cvs] [58f3b3c6d1b] master: Tracking: Fix use-after-free bug

Sergey Sharybin noreply at git.blender.org
Mon Apr 10 16:02:18 CEST 2017


Commit: 58f3b3c6d1bf1582662a697dd0a0e4b1a1b264db
Author: Sergey Sharybin
Date:   Mon Apr 10 16:01:58 2017 +0200
Branches: master
https://developer.blender.org/rB58f3b3c6d1bf1582662a697dd0a0e4b1a1b264db

Tracking: Fix use-after-free bug

===================================================================

M	source/blender/editors/space_clip/clip_utils.c

===================================================================

diff --git a/source/blender/editors/space_clip/clip_utils.c b/source/blender/editors/space_clip/clip_utils.c
index 547c2fba66f..be1fffec609 100644
--- a/source/blender/editors/space_clip/clip_utils.c
+++ b/source/blender/editors/space_clip/clip_utils.c
@@ -179,6 +179,7 @@ void clip_delete_track(bContext *C, MovieClip *clip, MovieTrackingTrack *track)
 	ListBase *tracksbase = BKE_tracking_get_active_tracks(tracking);
 	bool has_bundle = false;
 	char track_name_escaped[MAX_NAME], prefix[MAX_NAME * 2];
+	const bool used_for_stabilization = (track->flag & (TRACK_USE_2D_STAB | TRACK_USE_2D_STAB_ROT));
 
 	if (track == act_track)
 		tracking->act_track = NULL;
@@ -200,7 +201,7 @@ void clip_delete_track(bContext *C, MovieClip *clip, MovieTrackingTrack *track)
 
 	WM_event_add_notifier(C, NC_MOVIECLIP | NA_EDITED, clip);
 
-	if (track->flag & (TRACK_USE_2D_STAB | TRACK_USE_2D_STAB_ROT)) {
+	if (used_for_stabilization) {
 		WM_event_add_notifier(C, NC_MOVIECLIP | ND_DISPLAY, clip);
 	}




More information about the Bf-blender-cvs mailing list