[Bf-blender-cvs] [7f67885] master: Fix T49323: Ineffective bone roll calculation with low rig scale

Sergey Sharybin noreply at git.blender.org
Tue Sep 13 12:39:36 CEST 2016


Commit: 7f67885526ee925dafd7ff5c0813b404cebd8a5d
Author: Sergey Sharybin
Date:   Tue Sep 13 12:38:47 2016 +0200
Branches: master
https://developer.blender.org/rB7f67885526ee925dafd7ff5c0813b404cebd8a5d

Fix T49323: Ineffective bone roll calculation with low rig scale

The code was expecting vector to be normalized, however after
applying inverted object matrix it was possible to have scale
applied to it.

===================================================================

M	source/blender/editors/armature/armature_edit.c

===================================================================

diff --git a/source/blender/editors/armature/armature_edit.c b/source/blender/editors/armature/armature_edit.c
index 354b748..ece0f18 100644
--- a/source/blender/editors/armature/armature_edit.c
+++ b/source/blender/editors/armature/armature_edit.c
@@ -410,6 +410,7 @@ static int armature_calc_roll_exec(bContext *C, wmOperator *op)
 			if (type < 3) vec[type] = 1.0f;
 			else vec[type - 2] = -1.0f;
 			mul_m3_v3(imat, vec);
+			normalize_v3(vec);
 		}
 		
 		if (axis_flip) negate_v3(vec);




More information about the Bf-blender-cvs mailing list