[Bf-blender-cvs] [bd6a9fd] master: Fix (unreported) nodeRemoveAllSockets() not clearing inputs/outputs sockets lists.

Bastien Montagne noreply at git.blender.org
Sat Nov 19 14:58:05 CET 2016


Commit: bd6a9fd7341f5573451abe5924df94a06f9f168b
Author: Bastien Montagne
Date:   Sat Nov 19 12:16:14 2016 +0100
Branches: master
https://developer.blender.org/rBbd6a9fd7341f5573451abe5924df94a06f9f168b

Fix (unreported) nodeRemoveAllSockets() not clearing inputs/outputs sockets lists.

Nice crasher (though seems to not be much used so far)!

Related to T49991.

===================================================================

M	source/blender/blenkernel/intern/node.c

===================================================================

diff --git a/source/blender/blenkernel/intern/node.c b/source/blender/blenkernel/intern/node.c
index 2b88ae4..a227228 100644
--- a/source/blender/blenkernel/intern/node.c
+++ b/source/blender/blenkernel/intern/node.c
@@ -736,11 +736,14 @@ void nodeRemoveAllSockets(bNodeTree *ntree, bNode *node)
 		node_socket_free(ntree, sock, node);
 		MEM_freeN(sock);
 	}
+	BLI_listbase_clear(&node->inputs);
+
 	for (sock = node->outputs.first; sock; sock = sock_next) {
 		sock_next = sock->next;
 		node_socket_free(ntree, sock, node);
 		MEM_freeN(sock);
 	}
+	BLI_listbase_clear(&node->outputs);
 	
 	node->update |= NODE_UPDATE;
 }




More information about the Bf-blender-cvs mailing list