[Bf-blender-cvs] [209bc99] master: Fix T50046: Segmentation fault due to out-of-range VertexGroup.weight() call.

Bastien Montagne noreply at git.blender.org
Wed Nov 16 12:42:27 CET 2016


Commit: 209bc9977c9754d3ad5d4cf550a460eb56814686
Author: Bastien Montagne
Date:   Wed Nov 16 12:38:57 2016 +0100
Branches: master
https://developer.blender.org/rB209bc9977c9754d3ad5d4cf550a460eb56814686

Fix T50046: Segmentation fault due to out-of-range VertexGroup.weight() call.

`get_vert_def_nr()` was not checking vert index in bmesh case (aka Edit mode).

===================================================================

M	source/blender/editors/object/object_vgroup.c

===================================================================

diff --git a/source/blender/editors/object/object_vgroup.c b/source/blender/editors/object/object_vgroup.c
index 82da6f5..56f59dc 100644
--- a/source/blender/editors/object/object_vgroup.c
+++ b/source/blender/editors/object/object_vgroup.c
@@ -886,7 +886,7 @@ static float get_vert_def_nr(Object *ob, const int def_nr, const int vertnum)
 			const int cd_dvert_offset = CustomData_get_offset(&em->bm->vdata, CD_MDEFORMVERT);
 			/* warning, this lookup is _not_ fast */
 
-			if (cd_dvert_offset != -1) {
+			if (cd_dvert_offset != -1 && vertnum < em->bm->totvert) {
 				BMVert *eve;
 				BM_mesh_elem_table_ensure(em->bm, BM_VERT);
 				eve = BM_vert_at_index(em->bm, vertnum);




More information about the Bf-blender-cvs mailing list