[Bf-blender-cvs] [e316636] master: Fix `BKE_library_make_local()` trying to also make local proxified objects.

Bastien Montagne noreply at git.blender.org
Thu Nov 10 17:09:30 CET 2016


Commit: e316636fa84974fcfd989a8b4787535c4d250001
Author: Bastien Montagne
Date:   Thu Nov 10 17:05:36 2016 +0100
Branches: master
https://developer.blender.org/rBe316636fa84974fcfd989a8b4787535c4d250001

Fix `BKE_library_make_local()` trying to also make local proxified objects.

Proxified objects can never be local, we can totally ignore them here.

This 'fixes' the asserts related to usercount when trying to remap poselib
of localized proxified objects (not sure what exactly was going on wrong here,
but proxies are a giant can of worms for sane data-blocks handling anyway :/).

===================================================================

M	source/blender/blenkernel/intern/library.c

===================================================================

diff --git a/source/blender/blenkernel/intern/library.c b/source/blender/blenkernel/intern/library.c
index 14804d0..fc87dad 100644
--- a/source/blender/blenkernel/intern/library.c
+++ b/source/blender/blenkernel/intern/library.c
@@ -1672,9 +1672,10 @@ void BKE_library_make_local(
 			/* The check on the second line (LIB_TAG_PRE_EXISTING) is done so its
 			 * possible to tag data you don't want to be made local, used for
 			 * appending data, so any libdata already linked wont become local
-			 * (very nasty to discover all your links are lost after appending)  
-			 * */
+			 * (very nasty to discover all your links are lost after appending).
+			 * Also, never ever make proxified objects local, would not make any sense. */
 			if (!do_skip && id->tag & (LIB_TAG_EXTERN | LIB_TAG_INDIRECT | LIB_TAG_NEW) &&
+			    !(GS(id->name) == ID_OB && ((Object *)id)->proxy_from != NULL) &&
 			    ((untagged_only == false) || !(id->tag & LIB_TAG_PRE_EXISTING)))
 			{
 				if (lib == NULL || id->lib == lib) {




More information about the Bf-blender-cvs mailing list