[Bf-blender-cvs] [12d2329] master: Dyntopo: remove redundant existing face check

Campbell Barton noreply at git.blender.org
Mon Jul 11 09:15:32 CEST 2016


Commit: 12d2329d0e806bb61adf26fafaacd0b5f729740b
Author: Campbell Barton
Date:   Mon Jul 11 15:26:23 2016 +1000
Branches: master
https://developer.blender.org/rB12d2329d0e806bb61adf26fafaacd0b5f729740b

Dyntopo: remove redundant existing face check

Gives minor speedup

===================================================================

M	source/blender/blenkernel/intern/pbvh_bmesh.c

===================================================================

diff --git a/source/blender/blenkernel/intern/pbvh_bmesh.c b/source/blender/blenkernel/intern/pbvh_bmesh.c
index 45e3376..dcf3006 100644
--- a/source/blender/blenkernel/intern/pbvh_bmesh.c
+++ b/source/blender/blenkernel/intern/pbvh_bmesh.c
@@ -483,6 +483,9 @@ static BMVert *pbvh_bmesh_vert_create(
 	return v;
 }
 
+/**
+ * \note Callers are responsible for checking if the face exists before adding.
+ */
 static BMFace *pbvh_bmesh_face_create(
         PBVH *bvh, int node_index,
         BMVert *v_tri[3], BMEdge *e_tri[3],
@@ -493,7 +496,7 @@ static BMFace *pbvh_bmesh_face_create(
 	/* ensure we never add existing face */
 	BLI_assert(BM_face_exists(v_tri, 3, NULL) == false);
 
-	BMFace *f = BM_face_create(bvh->bm, v_tri, e_tri, 3, f_example, BM_CREATE_NO_DOUBLE);
+	BMFace *f = BM_face_create(bvh->bm, v_tri, e_tri, 3, f_example, BM_CREATE_NOP);
 	f->head.hflag = f_example->head.hflag;
 
 	BLI_gset_insert(node->bm_faces, f);




More information about the Bf-blender-cvs mailing list