[Bf-blender-cvs] [dad1cda] master: Revert "Make 'incompatible pointer type' gcc warning an error by default."

[Campbell Barton]

Commit: dad1cdad1352f486b73f0e4a657df656a5734766
Author: Campbell Barton
Date:   Sun Jan 17 13:18:41 2016 +1100
Branches: master
https://developer.blender.org/rBdad1cdad1352f486b73f0e4a657df656a5734766

Revert "Make 'incompatible pointer type' gcc warning an error by default."

This reverts commit b5bd39b5182590fd4d5ddb24d7b7bdbe714d57bf.

This is problematic because it means minor differences in system headers can cause errors
(glew in this case errored for me both with system and Blender's bundled version).

Developers can enable -Werror=* locally for warnings that aren't reliable across different systems.

===================================================================

M	CMakeLists.txt

===================================================================

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 949f04d..1a2aa81 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -2644,7 +2644,6 @@ if(CMAKE_COMPILER_IS_GNUCC)
 	ADD_CHECK_C_COMPILER_FLAG(C_WARNINGS C_WARN_ERROR_IMPLICIT_FUNCTION_DECLARATION -Werror=implicit-function-declaration)
 	ADD_CHECK_C_COMPILER_FLAG(C_WARNINGS C_WARN_ERROR_RETURN_TYPE  -Werror=return-type)
 	ADD_CHECK_C_COMPILER_FLAG(C_WARNINGS C_WARN_ERROR_VLA -Werror=vla)
-	ADD_CHECK_C_COMPILER_FLAG(C_WARNINGS C_WARN_ERROR_INCOMPATIBLE_POINTER_TYPE -Werror=incompatible-pointer-types)
 	# system headers sometimes do this, disable for now, was: -Werror=strict-prototypes
 	ADD_CHECK_C_COMPILER_FLAG(C_WARNINGS C_WARN_STRICT_PROTOTYPES  -Wstrict-prototypes)
 	ADD_CHECK_C_COMPILER_FLAG(C_WARNINGS C_WARN_MISSING_PROTOTYPES -Wmissing-prototypes)