[Bf-blender-cvs] [1c34a7f] master: Libmv: Fix missing virtual destructor in frame access sub-class

Sergey Sharybin noreply at git.blender.org
Tue Dec 20 12:29:44 CET 2016


Commit: 1c34a7f4ebc746236f9689c9bc1e6961ad9949e0
Author: Sergey Sharybin
Date:   Tue Dec 20 10:22:54 2016 +0100
Branches: master
https://developer.blender.org/rB1c34a7f4ebc746236f9689c9bc1e6961ad9949e0

Libmv: Fix missing virtual destructor in frame access sub-class

This is undefined behavior in C++ and Clang was complaining a lot
about this.

===================================================================

M	intern/libmv/intern/frame_accessor.cc

===================================================================

diff --git a/intern/libmv/intern/frame_accessor.cc b/intern/libmv/intern/frame_accessor.cc
index 9213cc3..5d274d7 100644
--- a/intern/libmv/intern/frame_accessor.cc
+++ b/intern/libmv/intern/frame_accessor.cc
@@ -45,6 +45,9 @@ struct LibmvFrameAccessor : public FrameAccessor {
       get_image_callback_(get_image_callback),
       release_image_callback_(release_image_callback) { }
 
+  virtual ~LibmvFrameAccessor() {
+  }
+
   libmv_InputMode get_libmv_input_mode(InputMode input_mode) {
     switch (input_mode) {
 #define CHECK_INPUT_MODE(mode) \




More information about the Bf-blender-cvs mailing list