[Bf-blender-cvs] [fbcd51a] master: Fix T50243: libmv_panography_test is broken

Sergey Sharybin noreply at git.blender.org
Wed Dec 14 10:46:23 CET 2016


Commit: fbcd51aef86a69fb99ae5cba51da6401f6c3dca4
Author: Sergey Sharybin
Date:   Wed Dec 14 10:44:57 2016 +0100
Branches: master
https://developer.blender.org/rBfbcd51aef86a69fb99ae5cba51da6401f6c3dca4

Fix T50243: libmv_panography_test is broken

There was fully wrong logic in comparison: was actually accessing memory
past the array boundary. Run test manually and the figure seems correct
to me now.

Spotted by @LazyDodo, thanks!

===================================================================

M	intern/libmv/libmv/multiview/panography_test.cc

===================================================================

diff --git a/intern/libmv/libmv/multiview/panography_test.cc b/intern/libmv/libmv/multiview/panography_test.cc
index f6faf0f..96d52ac 100644
--- a/intern/libmv/libmv/multiview/panography_test.cc
+++ b/intern/libmv/libmv/multiview/panography_test.cc
@@ -48,7 +48,7 @@ TEST(Panography, PrintSomeSharedFocalEstimationValues) {
 
   // Assert we found a valid solution.
   EXPECT_EQ(1, fs.size());
-  EXPECT_NEAR(1.01667, fs[1], 1e-3);
+  EXPECT_NEAR(3.47194, fs[0], 1e-3);
 }
 
 TEST(Panography, GetR_FixedCameraCenterWithIdentity) {




More information about the Bf-blender-cvs mailing list