[Bf-blender-cvs] [ebceb93] blender-v2.77-release: Fix T47902: Particle grid not using modifier stack.

Bastien Montagne noreply at git.blender.org
Tue Apr 5 10:51:32 CEST 2016


Commit: ebceb93bb497a8ddacfee410dc85a19161f9d183
Author: Bastien Montagne
Date:   Fri Mar 25 22:46:19 2016 +0100
Branches: blender-v2.77-release
https://developer.blender.org/rBebceb93bb497a8ddacfee410dc85a19161f9d183

Fix T47902: Particle grid not using modifier stack.

Disclaimer: this is tentative fix, seems to be working but you never know with particles.
If issue arise, we'll just revert this commit and hide 'use modifier stack' option
for grid distribution instead.

This commit also try to make choice of which dm to use during distribution more generic
(deduplication of code), again hopping not to break anything. :P

===================================================================

M	source/blender/blenkernel/intern/particle_distribute.c

===================================================================

diff --git a/source/blender/blenkernel/intern/particle_distribute.c b/source/blender/blenkernel/intern/particle_distribute.c
index 1c4099f..6d712ca 100644
--- a/source/blender/blenkernel/intern/particle_distribute.c
+++ b/source/blender/blenkernel/intern/particle_distribute.c
@@ -796,13 +796,23 @@ static int psys_thread_context_init_distribute(ParticleThreadContext *ctx, Parti
 	}
 	
 	psys_thread_context_init(ctx, sim);
-	
+
+	if (psys->part->use_modifier_stack)
+		dm = finaldm;
+	else
+		dm= CDDM_from_mesh((Mesh*)ob->data);
+
+	/* BMESH ONLY, for verts we don't care about tessfaces */
+	if (from != PART_FROM_VERT) {
+		DM_ensure_tessface(dm);
+	}
+
 	/* First handle special cases */
 	if (from == PART_FROM_CHILD) {
 		/* Simple children */
 		if (part->childtype != PART_CHILD_FACES) {
 			BLI_srandom(31415926 + psys->seed + psys->child_seed);
-			distribute_simple_children(scene, ob, finaldm, sim->psmd->dm_deformed, psys);
+			distribute_simple_children(scene, ob, dm, sim->psmd->dm_deformed, psys);
 			return 0;
 		}
 	}
@@ -810,10 +820,11 @@ static int psys_thread_context_init_distribute(ParticleThreadContext *ctx, Parti
 		/* Grid distribution */
 		if (part->distr==PART_DISTR_GRID && from != PART_FROM_VERT) {
 			BLI_srandom(31415926 + psys->seed);
-			dm= CDDM_from_mesh((Mesh*)ob->data);
-			DM_ensure_tessface(dm);
-			distribute_grid(dm,psys);
-			dm->release(dm);
+
+			distribute_grid(dm, psys);
+
+			if (dm != finaldm) dm->release(dm);
+
 			return 0;
 		}
 	}
@@ -822,10 +833,6 @@ static int psys_thread_context_init_distribute(ParticleThreadContext *ctx, Parti
 	if (from == PART_FROM_CHILD) {
 		distr=PART_DISTR_RAND;
 		BLI_srandom(31415926 + psys->seed + psys->child_seed);
-		dm= finaldm;
-
-		/* BMESH ONLY */
-		DM_ensure_tessface(dm);
 
 		children=1;
 
@@ -846,16 +853,6 @@ static int psys_thread_context_init_distribute(ParticleThreadContext *ctx, Parti
 		distr = part->distr;
 		BLI_srandom(31415926 + psys->seed);
 		
-		if (psys->part->use_modifier_stack)
-			dm = finaldm;
-		else
-			dm= CDDM_from_mesh((Mesh*)ob->data);
-
-		/* BMESH ONLY, for verts we don't care about tessfaces */
-		if (from != PART_FROM_VERT) {
-			DM_ensure_tessface(dm);
-		}
-
 		/* we need orco for consistent distributions */
 		if (!CustomData_has_layer(&dm->vertData, CD_ORCO))
 			DM_add_vert_layer(dm, CD_ORCO, CD_ASSIGN, BKE_mesh_orco_verts_get(ob));




More information about the Bf-blender-cvs mailing list