[Bf-blender-cvs] [836c69c] master: Cleanup: Add some notes in code for upcoming graph simplification process.

Thomas Dinges noreply at git.blender.org
Wed Nov 18 17:21:14 CET 2015


Commit: 836c69c92fb5992eb83c4311a98f5ffad4a172f5
Author: Thomas Dinges
Date:   Wed Nov 18 17:20:39 2015 +0100
Branches: master
https://developer.blender.org/rB836c69c92fb5992eb83c4311a98f5ffad4a172f5

Cleanup: Add some notes in code for upcoming graph simplification process.

===================================================================

M	intern/cycles/render/graph.cpp

===================================================================

diff --git a/intern/cycles/render/graph.cpp b/intern/cycles/render/graph.cpp
index 16e1ef7..a342eae 100644
--- a/intern/cycles/render/graph.cpp
+++ b/intern/cycles/render/graph.cpp
@@ -576,9 +576,25 @@ void ShaderGraph::break_cycles(ShaderNode *node, vector<bool>& visited, vector<b
 
 void ShaderGraph::clean()
 {
-	/* remove proxy and unnecessary nodes */
+	/* Graph simplification:
+	 *  1: Remove unnecesarry nodes
+	 *  2: Constant folding
+	 *  3: Simplification
+	 *  4: De-duplication
+	 */
+
+	/* 1: Remove proxy and unnecessary nodes. */
 	remove_unneeded_nodes();
 
+	/* 2: Constant folding. */
+	/* TODO(dingto): Implement */
+
+	/* 3: Simplification. */
+	/* TODO(dingto): Implement */
+
+	/* 4: De-duplication. */
+	/* TODO(dingto): Implement */
+
 	/* we do two things here: find cycles and break them, and remove unused
 	 * nodes that don't feed into the output. how cycles are broken is
 	 * undefined, they are invalid input, the important thing is to not crash */




More information about the Bf-blender-cvs mailing list