[Bf-blender-cvs] [be30070] master: BGE: Cleanup KX_BlenderSceneConverter.cpp

Porteries Tristan noreply at git.blender.org
Mon May 4 13:36:35 CEST 2015


Commit: be30070d869906f6fd12fc0ca8dd24b85f6e33b6
Author: Porteries Tristan
Date:   Mon May 4 13:32:28 2015 +0200
Branches: master
https://developer.blender.org/rBbe30070d869906f6fd12fc0ca8dd24b85f6e33b6

BGE: Cleanup KX_BlenderSceneConverter.cpp

This commit is a little cleanup for whitspaces, braces, spaces around operators and useless keywords struct/class.

Reviewers:sybren

===================================================================

M	source/gameengine/Converter/KX_BlenderSceneConverter.cpp

===================================================================

diff --git a/source/gameengine/Converter/KX_BlenderSceneConverter.cpp b/source/gameengine/Converter/KX_BlenderSceneConverter.cpp
index c5add2d..1a489c3 100644
--- a/source/gameengine/Converter/KX_BlenderSceneConverter.cpp
+++ b/source/gameengine/Converter/KX_BlenderSceneConverter.cpp
@@ -117,11 +117,9 @@ typedef struct ThreadInfo {
 } ThreadInfo;
 
 KX_BlenderSceneConverter::KX_BlenderSceneConverter(
-							struct Main* maggie,
-							class KX_KetsjiEngine* engine
-							)
-							: m_maggie(maggie),
-							/*m_maggie_dyn(NULL),*/
+							Main *maggie,
+							KX_KetsjiEngine *engine)
+							:m_maggie(maggie),
 							m_ketsjiEngine(engine),
 							m_alwaysUseExpandFraming(false),
 							m_usemat(false),
@@ -134,13 +132,11 @@ KX_BlenderSceneConverter::KX_BlenderSceneConverter(
 	pthread_mutex_init(&m_threadinfo->merge_lock, NULL);
 }
 
-
 KX_BlenderSceneConverter::~KX_BlenderSceneConverter()
 {
 	// clears meshes, and hashmaps from blender to gameengine data
-	int i;
 	// delete sumoshapes
-	
+
 	if (m_threadinfo) {
 		vector<pthread_t>::iterator pit = m_threadinfo->threads.begin();
 		while (pit != m_threadinfo->threads.end()) {
@@ -153,104 +149,83 @@ KX_BlenderSceneConverter::~KX_BlenderSceneConverter()
 	}
 
 	int numAdtLists = m_map_blender_to_gameAdtList.size();
-	for (i=0; i<numAdtLists; i++) {
-		BL_InterpolatorList *adtList= *m_map_blender_to_gameAdtList.at(i);
+	for (int i = 0; i < numAdtLists; i++) {
+		BL_InterpolatorList *adtList = *m_map_blender_to_gameAdtList.at(i);
 
 		delete (adtList);
 	}
 
-	vector<pair<KX_Scene*,KX_WorldInfo*> >::iterator itw = m_worldinfos.begin();
+	vector<pair<KX_Scene *, KX_WorldInfo *> >::iterator itw = m_worldinfos.begin();
 	while (itw != m_worldinfos.end()) {
 		delete (*itw).second;
 		itw++;
 	}
 	m_worldinfos.clear();
 
-	vector<pair<KX_Scene*,RAS_IPolyMaterial*> >::iterator itp = m_polymaterials.begin();
+	vector<pair<KX_Scene *,RAS_IPolyMaterial *> >::iterator itp = m_polymaterials.begin();
 	while (itp != m_polymaterials.end()) {
-		//m_polymat_cache.erase((*itp).second->GetBlenderMaterial());
 		delete (*itp).second;
 		itp++;
 	}
 	m_polymaterials.clear();
 
 	// delete after RAS_IPolyMaterial
-	vector<pair<KX_Scene*,BL_Material *> >::iterator itmat = m_materials.begin();
+	vector<pair<KX_Scene *,BL_Material *> >::iterator itmat = m_materials.begin();
 	while (itmat != m_materials.end()) {
-		//m_mat_cache.erase((*itmat).second->material);
 		delete (*itmat).second;
 		itmat++;
 	}
 	m_materials.clear();
 
-
-	vector<pair<KX_Scene*,RAS_MeshObject*> >::iterator itm = m_meshobjects.begin();
+	vector<pair<KX_Scene *,RAS_MeshObject *> >::iterator itm = m_meshobjects.begin();
 	while (itm != m_meshobjects.end()) {
 		delete (*itm).second;
 		itm++;
 	}
 	m_meshobjects.clear();
 
-
 	/* free any data that was dynamically loaded */
-	while (m_DynamicMaggie.size() != 0)
-	{
+	while (m_DynamicMaggie.size() != 0) {
 		FreeBlendFile(m_DynamicMaggie[0]);
 	}
 
 	m_DynamicMaggie.clear();
 }
 
-void KX_BlenderSceneConverter::SetNewFileName(const STR_String& filename)
+void KX_BlenderSceneConverter::SetNewFileName(const STR_String &filename)
 {
 	m_newfilename = filename;
 }
 
-
-
 bool KX_BlenderSceneConverter::TryAndLoadNewFile()
 {
 	bool result = false;
 
-	// find the file
-/*	if ()
-	{
-		result = true;
-	}
-	// if not, clear the newfilename
-	else
-	{
-		m_newfilename = "";
-	}
-*/
 	return result;
 }
 
-Scene *KX_BlenderSceneConverter::GetBlenderSceneForName(const STR_String& name)
+Scene *KX_BlenderSceneConverter::GetBlenderSceneForName(const STR_String &name)
 {
 	Scene *sce;
 
 	/**
 	 * Find the specified scene by name, or NULL if nothing matches.
 	 */
-	if ((sce= (Scene *)BLI_findstring(&m_maggie->scene, name.ReadPtr(), offsetof(ID, name) + 2)))
+	if ((sce = (Scene *)BLI_findstring(&m_maggie->scene, name.ReadPtr(), offsetof(ID, name) + 2)))
 		return sce;
 
-	for (vector<Main*>::iterator it=m_DynamicMaggie.begin(); !(it==m_DynamicMaggie.end()); it++) {
-		Main *main= *it;
+	for (vector<Main *>::iterator it=m_DynamicMaggie.begin(); !(it == m_DynamicMaggie.end()); it++) {
+		Main *main = *it;
 
 		if ((sce= (Scene *)BLI_findstring(&main->scene, name.ReadPtr(), offsetof(ID, name) + 2)))
 			return sce;
 	}
 
 	return NULL;
-
 }
 
-void KX_BlenderSceneConverter::ConvertScene(class KX_Scene* destinationscene,
-											class RAS_IRasterizer* rendertools,
-											class RAS_ICanvas* canvas,
-											bool libloading)
+void KX_BlenderSceneConverter::ConvertScene(KX_Scene *destinationscene, RAS_IRasterizer *rendertools,
+											RAS_ICanvas *canvas, bool libloading)
 {
 	//find out which physics engine
 	Scene *blenderscene = destinationscene->GetBlenderScene();
@@ -266,13 +241,12 @@ void KX_BlenderSceneConverter::ConvertScene(class KX_Scene* destinationscene,
 	// when doing threaded conversion, so it's disabled for now.
 	// SG_SetActiveStage(SG_STAGE_CONVERTER);
 
-	switch (blenderscene->gm.physicsEngine)
-	{
+	switch (blenderscene->gm.physicsEngine) {
 #ifdef WITH_BULLET
 	case WOPHY_BULLET:
 		{
 			SYS_SystemHandle syshandle = SYS_GetSystem(); /*unused*/
-			int visualizePhysics = SYS_GetCommandLineInt(syshandle,"show_physics",0);
+			int visualizePhysics = SYS_GetCommandLineInt(syshandle, "show_physics", 0);
 
 			phy_env = CcdPhysicsEnvironment::Create(blenderscene, visualizePhysics);
 			physics_engine = UseBullet;
@@ -291,7 +265,8 @@ void KX_BlenderSceneConverter::ConvertScene(class KX_Scene* destinationscene,
 
 	destinationscene->SetPhysicsEnvironment(phy_env);
 
-	BL_ConvertBlenderObjects(m_maggie,
+	BL_ConvertBlenderObjects(
+		m_maggie,
 		destinationscene,
 		m_ketsjiEngine,
 		physics_engine,
@@ -299,8 +274,7 @@ void KX_BlenderSceneConverter::ConvertScene(class KX_Scene* destinationscene,
 		canvas,
 		this,
 		m_alwaysUseExpandFraming,
-		libloading
-		);
+		libloading);
 
 	//These lookup are not needed during game
 	m_map_blender_to_gameactuator.clear();
@@ -326,30 +300,32 @@ void KX_BlenderSceneConverter::RemoveScene(KX_Scene *scene)
 	// delete the scene first as it will stop the use of entities
 	delete scene;
 	// delete the entities of this scene
-	vector<pair<KX_Scene*,KX_WorldInfo*> >::iterator worldit;
+	vector<pair<KX_Scene *, KX_WorldInfo *> >::iterator worldit;
 	size = m_worldinfos.size();
-	for (i=0, worldit=m_worldinfos.begin(); i<size; ) {
+	for (i = 0, worldit = m_worldinfos.begin(); i < size; ) {
 		if ((*worldit).first == scene) {
 			delete (*worldit).second;
 			*worldit = m_worldinfos.back();
 			m_worldinfos.pop_back();
 			size--;
-		} else {
+		} 
+		else {
 			i++;
 			worldit++;
 		}
 	}
 
-	vector<pair<KX_Scene*,RAS_IPolyMaterial*> >::iterator polymit;
+	vector<pair<KX_Scene *, RAS_IPolyMaterial *> >::iterator polymit;
 	size = m_polymaterials.size();
-	for (i=0, polymit=m_polymaterials.begin(); i<size; ) {
+	for (i = 0, polymit = m_polymaterials.begin(); i < size; ) {
 		if ((*polymit).first == scene) {
 			m_polymat_cache[scene].erase((*polymit).second->GetBlenderMaterial());
 			delete (*polymit).second;
 			*polymit = m_polymaterials.back();
 			m_polymaterials.pop_back();
 			size--;
-		} else {
+		} 
+		else {
 			i++;
 			polymit++;
 		}
@@ -357,16 +333,17 @@ void KX_BlenderSceneConverter::RemoveScene(KX_Scene *scene)
 
 	m_polymat_cache.erase(scene);
 
-	vector<pair<KX_Scene*,BL_Material*> >::iterator matit;
+	vector<pair<KX_Scene *, BL_Material *> >::iterator matit;
 	size = m_materials.size();
-	for (i=0, matit=m_materials.begin(); i<size; ) {
+	for (i = 0, matit = m_materials.begin(); i < size; ) {
 		if ((*matit).first == scene) {
 			m_mat_cache[scene].erase((*matit).second->material);
 			delete (*matit).second;
 			*matit = m_materials.back();
 			m_materials.pop_back();
 			size--;
-		} else {
+		} 
+		else {
 			i++;
 			matit++;
 		}
@@ -374,15 +351,16 @@ void KX_BlenderSceneConverter::RemoveScene(KX_Scene *scene)
 
 	m_mat_cache.erase(scene);
 
-	vector<pair<KX_Scene*,RAS_MeshObject*> >::iterator meshit;
+	vector<pair<KX_Scene *, RAS_MeshObject *> >::iterator meshit;
 	size = m_meshobjects.size();
-	for (i=0, meshit=m_meshobjects.begin(); i<size; ) {
+	for (i = 0, meshit = m_meshobjects.begin(); i < size; ) {
 		if ((*meshit).first == scene) {
 			delete (*meshit).second;
 			*meshit = m_meshobjects.back();
 			m_meshobjects.pop_back();
 			size--;
-		} else {
+		} 
+		else {
 			i++;
 			meshit++;
 		}
@@ -425,43 +403,34 @@ bool KX_BlenderSceneConverter::GetCacheMaterials()
 void KX_BlenderSceneConverter::RegisterBlenderMaterial(BL_Material *mat)
 {
 	// First make sure we don't register the material twice
-	vector<pair<KX_Scene*,BL_Material*> >::iterator it;
+	vector<pair<KX_Scene *, BL_Material *> >::iterator it;
 	for (it = m_materials.begin(); it != m_materials.end(); ++it)
 		if (it->second == mat)
 			return;
 
-	m_materials.push_back(pair<KX_Scene*,BL_Material *>(m_currentScene,mat));
+	m_materials.push_back(pair<KX_Scene *, BL_Material *> (m_currentScene, mat));
 }
 
-
-
-void KX_BlenderSceneConverter::SetAlwaysUseExpandFraming(
-	bool to_what)
+void KX_BlenderSceneConverter::SetAlwaysUseExpandFraming(bool to_what)
 {
 	m_alwaysUseExpandFraming= to_what;
 }
 
-	
-
-void KX_BlenderSceneConverter::RegisterGameObject(
-									KX_GameObject *gameobject, 
-									struct Object *for_blenderobject) 
+void KX_BlenderSceneConverter::RegisterGameObject(KX_GameObject *gameobject, Object *for_blenderobject) 
 {
 	/* only maintained while converting, freed during game runtime */
-	m_map_blender_to_gameobject.insert(CHashedPtr(for_blenderobject),gameobject);
+	m_map_blender_to_gameobject.insert(CHashedPtr(for_blenderobject), gameobject);
 }
 
 /* only need to run this during conversion since
  * m_map_blender_to_gameobject is freed after conversion */
-void KX_BlenderSceneConverter::UnregisterGameObject(
-									KX_GameObject *gameobject) 
+void KX_BlenderSceneConverter::UnregisterGameObject(KX_GameObject *gameobject) 
 {
-	struct Object *bobp= gameobject->GetBlenderObject();
+	Object *bobp = gameobject->GetBlenderObject();
 	if (bobp) {
 		CHashedPtr bptr(bobp);
-		KX_GameObject **gobp= m_map_blender_to_gameobject[bptr];
-		if (gobp && *gobp == gameobject)
-		{
+		KX_GameObject **gobp = m_map_blender_to_gameobject[bpt

@@ Diff output truncated at 10240 characters. @@




More information about the Bf-blender-cvs mailing list