[Bf-blender-cvs] [79ffa03] master: Compositor: Add note that bilateral blur is not really correct

[Sergey Sharybin]

Commit: 79ffa03620cdd29b0cd234092ae4ebe2d82a5bec
Author: Sergey Sharybin
Date:   Mon Jul 27 14:14:17 2015 +0200
Branches: master
https://developer.blender.org/rB79ffa03620cdd29b0cd234092ae4ebe2d82a5bec

Compositor: Add note that bilateral blur is not really correct

The code does stupid box filter which doesn't give nice results and doesn't
match old compositor at all. Need some better gaussian weighting here. Will
look into it later.

===================================================================

M	source/blender/compositor/operations/COM_BilateralBlurOperation.cpp

===================================================================

diff --git a/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp b/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp
index 2527f13..b24e48f 100644
--- a/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp
+++ b/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp
@@ -65,6 +65,10 @@ void BilateralBlurOperation::executePixel(float output[4], int x, int y, void *d
 
 	zero_v4(blurColor);
 	blurDivider = 0.0f;
+	/* TODO(sergey): This isn't really good bilateral filter, it should be
+	 * using gaussian bell for weights. Also sigma_color doesn't seem to be
+	 * used correct at all.
+	 */
 	for (int yi = miny; yi < maxy; yi += QualityStepHelper::getStep()) {
 		for (int xi = minx; xi < maxx; xi += QualityStepHelper::getStep()) {
 			// read determinator