[Bf-blender-cvs] [bd10b72] master: Fix T43458: Crashes with hair transmission BSDF

Sergey Sharybin noreply at git.blender.org
Fri Jan 30 11:13:53 CET 2015


Commit: bd10b72ad38eea117ee440567c1e2edb04970f36
Author: Sergey Sharybin
Date:   Fri Jan 30 13:03:01 2015 +0500
Branches: master
https://developer.blender.org/rBbd10b72ad38eea117ee440567c1e2edb04970f36

Fix T43458: Crashes with hair transmission BSDF

Hair BSDF did not have proper behavior because of non-normalized
tangent direction (which it expected to be normalized).This lead
to wrong labels being returned by the hair BSDF samplers.

===================================================================

M	intern/cycles/kernel/svm/svm_closure.h

===================================================================

diff --git a/intern/cycles/kernel/svm/svm_closure.h b/intern/cycles/kernel/svm/svm_closure.h
index e4e3b68..ed3f277 100644
--- a/intern/cycles/kernel/svm/svm_closure.h
+++ b/intern/cycles/kernel/svm/svm_closure.h
@@ -402,7 +402,7 @@ ccl_device void svm_node_closure_bsdf(KernelGlobals *kg, ShaderData *sd, float *
 						sc->data2 = 0.0f;
 					}
 					else
-						sc->T = sd->dPdu;
+						sc->T = normalize(sd->dPdu);
 
 					if(type == CLOSURE_BSDF_HAIR_REFLECTION_ID) {
 						sd->flag |= bsdf_hair_reflection_setup(sc);




More information about the Bf-blender-cvs mailing list