[Bf-blender-cvs] [03fbe5d] depsgraph_refactor: WIP - Noting insights

Joshua Leung noreply at git.blender.org
Fri Jan 23 15:58:51 CET 2015


Commit: 03fbe5db06de64939a41772c94f2cd20a6192a70
Author: Joshua Leung
Date:   Fri Jan 23 00:36:10 2015 +1300
Branches: depsgraph_refactor
https://developer.blender.org/rB03fbe5db06de64939a41772c94f2cd20a6192a70

WIP - Noting insights

===================================================================

M	source/blender/depsgraph/intern/depsgraph_build_relations.cpp

===================================================================

diff --git a/source/blender/depsgraph/intern/depsgraph_build_relations.cpp b/source/blender/depsgraph/intern/depsgraph_build_relations.cpp
index 11fa28f..f51ac9a 100644
--- a/source/blender/depsgraph/intern/depsgraph_build_relations.cpp
+++ b/source/blender/depsgraph/intern/depsgraph_build_relations.cpp
@@ -535,6 +535,9 @@ void DepsgraphRelationBuilder::build_constraints(Scene *scene, ID *id, eDepsNode
 					if (&ct->tar->id == id) {
 						/* same armature - use the "ready" state only, to avoid collisions with IK */
 						/* NOTE: in some cases, this may break (i.e. if the target is in a separate chain which can get safely evaluated first) */
+						// XXX: using "done" here breaks in-chain deps, while using "ready" here breaks most production rigs instead... Maybe we need the rootmap checks here?
+
+						//OperationKey target_key(&ct->tar->id, DEPSNODE_TYPE_BONE, ct->subtarget, DEG_OPCODE_BONE_READY);
 						OperationKey target_key(&ct->tar->id, DEPSNODE_TYPE_BONE, ct->subtarget, DEG_OPCODE_BONE_DONE);
 						add_relation(target_key, constraint_op_key, DEPSREL_TYPE_TRANSFORM, cti->name);
 					}




More information about the Bf-blender-cvs mailing list