[Bf-blender-cvs] [578cc21] master: Cycles: Add note about autodiff in OSL wireframe shader

Sergey Sharybin noreply at git.blender.org
Sat Feb 21 13:32:11 CET 2015


Commit: 578cc2143d36d1d4ab3ef9583a5b207034b01f89
Author: Sergey Sharybin
Date:   Sat Feb 21 17:31:41 2015 +0500
Branches: master
https://developer.blender.org/rB578cc2143d36d1d4ab3ef9583a5b207034b01f89

Cycles: Add note about autodiff in OSL wireframe shader

===================================================================

M	intern/cycles/kernel/shaders/node_wireframe.osl

===================================================================

diff --git a/intern/cycles/kernel/shaders/node_wireframe.osl b/intern/cycles/kernel/shaders/node_wireframe.osl
index 1ab0a65..5cc2144 100644
--- a/intern/cycles/kernel/shaders/node_wireframe.osl
+++ b/intern/cycles/kernel/shaders/node_wireframe.osl
@@ -24,6 +24,10 @@ shader node_wireframe(
 	output float Fac = 0.0)
 {
 	Fac = wireframe("triangles", Size, use_pixel_size);
+	/* TODO(sergey): Since we can't use autodiff here we do algebraic
+	 * calculation of derivatives by definition. We could probably
+	 * optimize this a bit by doing some extra calculation in wireframe().
+	 */
 	if (bump_offset == "dx") {
 		point dx = Dx(P);
 		P -= dx;
@@ -35,4 +39,3 @@ shader node_wireframe(
 		Fac += (Fac - wireframe("triangles", Size, use_pixel_size)) / length(dy);
 	}
 }
-




More information about the Bf-blender-cvs mailing list