[Bf-blender-cvs] [86a2e9d] master: etch-a-ton: off by one error

Campbell Barton noreply at git.blender.org
Tue Feb 17 07:22:26 CET 2015


Commit: 86a2e9d0e42ba1dbb31bf1e8cda94ea7db38544d
Author: Campbell Barton
Date:   Tue Feb 17 17:12:19 2015 +1100
Branches: master
https://developer.blender.org/rB86a2e9d0e42ba1dbb31bf1e8cda94ea7db38544d

etch-a-ton: off by one error

was writing past the buffer when inserting strokes

===================================================================

M	source/blender/blenkernel/intern/sketch.c

===================================================================

diff --git a/source/blender/blenkernel/intern/sketch.c b/source/blender/blenkernel/intern/sketch.c
index f9c5e8f..0d355ab 100644
--- a/source/blender/blenkernel/intern/sketch.c
+++ b/source/blender/blenkernel/intern/sketch.c
@@ -196,14 +196,14 @@ void sk_appendStrokePoint(SK_Stroke *stk, SK_Point *pt)
 
 void sk_insertStrokePoints(SK_Stroke *stk, SK_Point *pts, int len, int start, int end)
 {
-	int size = end - start + 1;
+	int size = end - start;
 
 	sk_growStrokeBufferN(stk, len - size);
 
 	if (len != size) {
-		int tail_size = stk->nb_points - end + 1;
+		int tail_size = stk->nb_points - end;
 
-		memmove(stk->points + start + len, stk->points + end + 1, tail_size * sizeof(SK_Point));
+		memmove(stk->points + start + len, stk->points + end, tail_size * sizeof(SK_Point));
 	}
 
 	memcpy(stk->points + start, pts, len * sizeof(SK_Point));




More information about the Bf-blender-cvs mailing list