[Bf-blender-cvs] [2ba1274] cycles-ptex-49: Fix ImBuf memory leak in Ptex

Nicholas Bishop noreply at git.blender.org
Mon Feb 9 12:11:11 CET 2015


Commit: 2ba12746864746023fe7be298747a05b0615f4ba
Author: Nicholas Bishop
Date:   Mon Feb 9 12:10:56 2015 +0100
Branches: cycles-ptex-49
https://developer.blender.org/rB2ba12746864746023fe7be298747a05b0615f4ba

Fix ImBuf memory leak in Ptex

===================================================================

M	source/blender/blenkernel/intern/bke_ptex.c

===================================================================

diff --git a/source/blender/blenkernel/intern/bke_ptex.c b/source/blender/blenkernel/intern/bke_ptex.c
index ee9b4ae..e480cb6 100644
--- a/source/blender/blenkernel/intern/bke_ptex.c
+++ b/source/blender/blenkernel/intern/bke_ptex.c
@@ -677,7 +677,11 @@ static bool ptex_pack_loops(Image **image, Mesh *me, MLoopPtex *loop_ptex)
 
 	(*image) = BKE_image_add_from_imbuf(ibuf);
 
-	return true;
+	/* Image now owns the ImBuf */
+	IMB_freeImBuf(ibuf);
+
+	/* Return true only if Image was created successfully */
+	return (*image) != NULL;
 }
 
 Image *BKE_ptex_mesh_image_get(struct Object *ob,




More information about the Bf-blender-cvs mailing list