[Bf-blender-cvs] [b176206] master: View3D: measure smoothview angle comparing quat angles

Campbell Barton noreply at git.blender.org
Tue Dec 22 19:30:05 CET 2015


Commit: b176206b94e8ca2e02c8350f08c9020881c777e3
Author: Campbell Barton
Date:   Wed Dec 23 05:09:25 2015 +1100
Branches: master
https://developer.blender.org/rBb176206b94e8ca2e02c8350f08c9020881c777e3

View3D: measure smoothview angle comparing quat angles

Rolling the view registered as no angle-difference.

===================================================================

M	source/blender/editors/space_view3d/view3d_view.c

===================================================================

diff --git a/source/blender/editors/space_view3d/view3d_view.c b/source/blender/editors/space_view3d/view3d_view.c
index 1b1ebc9..67504b2 100644
--- a/source/blender/editors/space_view3d/view3d_view.c
+++ b/source/blender/editors/space_view3d/view3d_view.c
@@ -268,17 +268,8 @@ void ED_view3d_smooth_view_ex(
 			 * the angle between quats 
 			 * this means small rotations wont lag */
 			if (sview->quat && !sview->ofs && !sview->dist) {
-				float vec1[3] = {0, 0, 1}, vec2[3] = {0, 0, 1};
-				float q1[4], q2[4];
-
-				invert_qt_qt_normalized(q1, sms.dst.quat);
-				invert_qt_qt_normalized(q2, sms.src.quat);
-
-				mul_qt_v3(q1, vec1);
-				mul_qt_v3(q2, vec2);
-
 				/* scale the time allowed by the rotation */
-				sms.time_allowed *= (double)angle_v3v3(vec1, vec2) / M_PI; /* 180deg == 1.0 */
+				sms.time_allowed *= (double)angle_normalized_qtqt(sms.dst.quat, sms.src.quat) / M_PI; /* 180deg == 1.0 */
 			}
 
 			/* ensure it shows correct */




More information about the Bf-blender-cvs mailing list