[Bf-blender-cvs] [0334be9] master: Don't error of sign-conversion for < gcc v4.8

Campbell Barton noreply at git.blender.org
Mon Sep 29 03:02:18 CEST 2014


Commit: 0334be9f7f5abdda0ee48b8b39b694ddb93405dd
Author: Campbell Barton
Date:   Mon Sep 29 10:57:46 2014 +1000
Branches: master
https://developer.blender.org/rB0334be9f7f5abdda0ee48b8b39b694ddb93405dd

Don't error of sign-conversion for < gcc v4.8

Behavior is different and hard to keep building on older versions.

===================================================================

M	source/blender/blenlib/BLI_strict_flags.h

===================================================================

diff --git a/source/blender/blenlib/BLI_strict_flags.h b/source/blender/blenlib/BLI_strict_flags.h
index 1d595ff..964ee06 100644
--- a/source/blender/blenlib/BLI_strict_flags.h
+++ b/source/blender/blenlib/BLI_strict_flags.h
@@ -28,13 +28,15 @@
  */
 
 #ifdef __GNUC__
-#  pragma GCC diagnostic error "-Wsign-conversion"
 #  if (__GNUC__ * 100 + __GNUC_MINOR__) >= 406  /* gcc4.6+ only */
 #    pragma GCC diagnostic error "-Wsign-compare"
 #    pragma GCC diagnostic error "-Wconversion"
 #  endif
-#  if (__GNUC__ * 100 + __GNUC_MINOR__) >= 408  /* gcc4.8+ only (behavior changed to ignore globals)*/
+#  if (__GNUC__ * 100 + __GNUC_MINOR__) >= 408
+     /* gcc4.8+ only (behavior changed to ignore globals)*/
 #    pragma GCC diagnostic error "-Wshadow"
+     /* older gcc changed behavior with ternary */
+#    pragma GCC diagnostic error "-Wsign-conversion"
 #  endif
 /* pedantic gives too many issues, developers can define this for own use */
 #  ifdef WARN_PEDANTIC




More information about the Bf-blender-cvs mailing list