[Bf-blender-cvs] [2f1192d] hair_immediate_fixes: Removed arbitrary factor 2.0 on volumetric hair friction factor.

Lukas Tönne noreply at git.blender.org
Fri Oct 31 16:34:34 CET 2014


Commit: 2f1192d302e19839b26da6261ae0dcd11e5cdde5
Author: Lukas Tönne
Date:   Fri Oct 31 16:30:54 2014 +0100
Branches: hair_immediate_fixes
https://developer.blender.org/rB2f1192d302e19839b26da6261ae0dcd11e5cdde5

Removed arbitrary factor 2.0 on volumetric hair friction factor.

This was introducing energy into the system for any factor beyond 0.5
and caused major instability.

===================================================================

M	source/blender/physics/intern/BPH_mass_spring.cpp

===================================================================

diff --git a/source/blender/physics/intern/BPH_mass_spring.cpp b/source/blender/physics/intern/BPH_mass_spring.cpp
index 85f0b4c..c0aef6e 100644
--- a/source/blender/physics/intern/BPH_mass_spring.cpp
+++ b/source/blender/physics/intern/BPH_mass_spring.cpp
@@ -706,9 +706,7 @@ static void cloth_continuum_step(ClothModifierData *clmd)
 	ClothVertex *vert;
 	
 	const float fluid_factor = 0.95f; /* blend between PIC and FLIP methods */
-	/* 2.0f is an experimental value that seems to give good results */
-	float smoothfac = 2.0f * parms->velocity_smooth;
-	float collfac = 2.0f * parms->collider_friction;
+	float smoothfac = parms->velocity_smooth;
 	float pressfac = parms->pressure;
 	float minpress = parms->pressure_threshold;
 	float gmin[3], gmax[3];




More information about the Bf-blender-cvs mailing list