[Bf-blender-cvs] [a6e05ad] multiview: From review: replace sprintf by BLI_snprintf

Dalai Felinto noreply at git.blender.org
Wed Nov 26 19:44:59 CET 2014


Commit: a6e05ad1dca189bac1de4263febbeb0ed08c46fd
Author: Dalai Felinto
Date:   Tue Nov 25 23:34:06 2014 -0200
Branches: multiview
https://developer.blender.org/rBa6e05ad1dca189bac1de4263febbeb0ed08c46fd

>From review: replace sprintf by BLI_snprintf

===================================================================

M	source/blender/blenkernel/intern/image.c
M	source/blender/blenkernel/intern/sequencer.c

===================================================================

diff --git a/source/blender/blenkernel/intern/image.c b/source/blender/blenkernel/intern/image.c
index 2a5a641..6f44acc 100644
--- a/source/blender/blenkernel/intern/image.c
+++ b/source/blender/blenkernel/intern/image.c
@@ -4431,7 +4431,7 @@ static void image_update_views_format(Scene *scene, Image *ima)
 				iv = MEM_mallocN(sizeof(ImageView), "Image View (open)");
 				BLI_strncpy(iv->name, srv->name, sizeof(iv->name));
 
-				sprintf(iv->filepath, "%s%s%s", prefix, srv->suffix, ext);
+				BLI_snprintf(iv->filepath, sizeof(iv->filepath), "%s%s%s", prefix, srv->suffix, ext);
 				BLI_addtail(&ima->views, iv);
 			}
 		}
diff --git a/source/blender/blenkernel/intern/sequencer.c b/source/blender/blenkernel/intern/sequencer.c
index 105c30d..2d63ef2 100644
--- a/source/blender/blenkernel/intern/sequencer.c
+++ b/source/blender/blenkernel/intern/sequencer.c
@@ -790,7 +790,7 @@ static void seq_multiview_name(Scene *scene, const size_t view_id, const char *p
 {
 	const char *viewname = BKE_scene_render_view_name_get(&scene->r, view_id);
 	const char *suffix = BKE_scene_view_suffix_get(&scene->r, viewname);
-	sprintf(r_path, "%s%s%s", prefix, suffix, ext);
+	BLI_snprintf(r_path, sizeof(r_path), "%s%s%s", prefix, suffix, ext);
 }
 
 /* note: caller should run BKE_sequence_calc(scene, seq) after */
@@ -1460,7 +1460,7 @@ static void seq_open_anim_file(Scene *scene, Sequence *seq)
 			StripAnim *sanim = MEM_mallocN(sizeof(StripAnim), "Strip Anim");
 			BLI_addtail(&seq->anims, sanim);
 
-			sprintf(str, "%s%s%s", prefix, suffix, ext);
+			BLI_snprintf(str, sizeof(str), "%s%s%s", prefix, suffix, ext);
 
 			sanim->anim = openanim(str, IB_rect | ((seq->flag & SEQ_FILTERY) ? IB_animdeinterlace : 0),
 			                       seq->streamindex, seq->strip->colorspace_settings.name);




More information about the Bf-blender-cvs mailing list