[Bf-blender-cvs] [6876c3b] depsgraph_refactor: Depsgraph: Playback doesn't crash now

Sergey Sharybin noreply at git.blender.org
Thu Nov 6 11:39:04 CET 2014


Commit: 6876c3b4588e798dc8ffee95a333aaff443f593a
Author: Sergey Sharybin
Date:   Thu Nov 6 11:36:03 2014 +0100
Branches: depsgraph_refactor
https://developer.blender.org/rB6876c3b4588e798dc8ffee95a333aaff443f593a

Depsgraph: Playback doesn't crash now

The time source is expected to be in the root depsgraph node for now,
so we should add it to there instead of the scene node.

This raises some questions:

- Who don't we have Scene ID node in the graph so far?
- Do we really need a time as an operation node, or it's something
  more up to the EvaluationContext.

Later one raises the bigger design question: what should we try to
do with the depsgraph and what is we're gonna to solve with the
evaluation context?

The answer here should be: everything which describes the (sub)graph
state should be in the evaluation context. This way this context will
finally become some key which totally corresponds to the (sub)scene
state.

===================================================================

M	source/blender/depsgraph/intern/depsgraph_build_nodes.cpp

===================================================================

diff --git a/source/blender/depsgraph/intern/depsgraph_build_nodes.cpp b/source/blender/depsgraph/intern/depsgraph_build_nodes.cpp
index 6d69bb1..4548edf 100644
--- a/source/blender/depsgraph/intern/depsgraph_build_nodes.cpp
+++ b/source/blender/depsgraph/intern/depsgraph_build_nodes.cpp
@@ -107,7 +107,7 @@ extern "C" {
 void DepsgraphNodeBuilder::build_scene(Scene *scene)
 {
 	/* timesource */
-	add_time_source(&scene->id);
+	add_time_source(NULL);
 	
 	/* build subgraph for set, and link this in... */
 	// XXX: depending on how this goes, that scene itself could probably store its




More information about the Bf-blender-cvs mailing list